-
Notifications
You must be signed in to change notification settings - Fork 18
Change the attribute name to enable the no duplicate methods rule. #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
in the end, I will use the same |
|
@smusali hold on with the rails changes. I am going to make a deeper research on the reasons for having a separate Rails lib in the form we have and the reasons for having it at all. We will probably get rid of it. |
@vilyapilya, not touching the codebase - just adding the same |
|
@smusali I mean that the work might be redundant if we decide to get rid of the rails library (I am for preserving time and energy =) ) but it's up to you of course. No harm indeed. |
33f56ce to
d111e6f
Compare
smusali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from my point of view, it looks good!
@dchai76, do you have any other comment?
Rename the attribute
Change the rules for mutable strings.
Remove autocorrection from circleci