Skip to content

Conversation

@vilyapilya
Copy link
Contributor

Rename the attribute
Change the rules for mutable strings.
Remove autocorrection from circleci

@smusali
Copy link
Contributor

smusali commented Dec 21, 2019

in the end, I will use the same .rubocop.yml for rails too after getting the updates merged in here

@vilyapilya
Copy link
Contributor Author

@smusali hold on with the rails changes. I am going to make a deeper research on the reasons for having a separate Rails lib in the form we have and the reasons for having it at all. We will probably get rid of it.

@smusali
Copy link
Contributor

smusali commented Dec 21, 2019

@smusali hold on with the rails changes. I am going to make a deeper research on the reasons for having a separate Rails lib in the form we have and the reasons for having it at all. We will probably get rid of it.

@vilyapilya, not touching the codebase - just adding the same .rubocop.yml - we can get rid of that later and there is no harm in updating .rubocop.yml there

@vilyapilya
Copy link
Contributor Author

vilyapilya commented Dec 21, 2019

@smusali I mean that the work might be redundant if we decide to get rid of the rails library (I am for preserving time and energy =) ) but it's up to you of course. No harm indeed.

@smusali smusali self-requested a review January 7, 2020 13:28
Copy link
Contributor

@smusali smusali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from my point of view, it looks good!

@dchai76, do you have any other comment?

@vilyapilya vilyapilya merged commit dd2ffdd into master Jan 8, 2020
@jakedipity jakedipity deleted the changeLevelName branch January 25, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants