Skip to content

Change the attribute name to enable the no duplicate methods rule. #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vilyapilya merged 6 commits into from
Jan 8, 2020
Merged

Change the attribute name to enable the no duplicate methods rule. #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8923255
rename the attribute and remove autocorrect from lints
lvilya Dec 21, 2019
46efe7c
remove the automatically added freexes
lvilya Dec 21, 2019
1bc082d
remove log_level from accessors:
lvilya Dec 21, 2019
463ba2a
remove requirement
lvilya Jan 2, 2020
d111e6f
edit rubocop
lvilya Jan 2, 2020
5a048fc
run rubocop -a
lvilya Jan 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ Style/IfUnlessModifier:
Enabled: false

Lint/DuplicateMethods:
Enabled: false
Enabled: true

Style/RedundantSelf:
Enabled: false
Expand Down
12 changes: 6 additions & 6 deletions lib/logdna.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ class Ruby < ::Logger
# uncomment line below and line 3 to enforce singleton
# include Singleton
Logger::TRACE = 5
attr_accessor :level, :app, :env, :meta
attr_accessor :app, :env, :meta

def initialize(key, opts = {})
@app = opts[:app] || "default"
@level = opts[:level] || "INFO"
@log_level = opts[:level] || "INFO"
@env = opts[:env]
@meta = opts[:meta]
@internal_logger = Logger.new(STDOUT)
Expand All @@ -46,19 +46,19 @@ def initialize(key, opts = {})
def default_opts
{
app: @app,
level: @level,
level: @log_level,
env: @env,
meta: @meta,
}
end

def level=(value)
if value.is_a? Numeric
@level = Resources::LOG_LEVELS[value]
@log_level = Resources::LOG_LEVELS[value]
return
end

@level = value
@log_level = value
end

def log(message = nil, opts = {})
Expand Down Expand Up @@ -93,7 +93,7 @@ def log(message = nil, opts = {})

def clear
@app = "default"
@level = "INFO"
@log_level = "INFO"
@env = nil
@meta = nil
end
Expand Down