-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Description
Description / Steps to reproduce / Feature proposal
When we have changes to an example repository that is dependent on changes in a published @loopback/* package, (feature / fix / anything breaking), between the time the PR is merged and a release is published to npm, any new examples cloned via lb4 example will break as it relies on code in master for dependencies.
This happened for 3 days in a row due to 3 different changes to our code base. Using master might be acceptable once we GA, but during alpha I think we need a better way of dealing with these changes.
Option 1
- Publish
example-*packages tonpmand have thelb4 examplescript use the published package to clone the project instead ofmasterOR even the latesttaggedversion on GitHub
Option 2
Automate releases using Travis. If a PR is merged, Travis can automatically do a release.
Current Behavior
lb4 example getting-started will clone the project from master
Expected Behavior
lb4 example getting-started should clone the last released / stable version of the project so the project doesn't break till new versions of @loopback/* are released.
See Reporting Issues for more tips on writing good issues
Acceptance Criteria
- Make all examples public npm packages again - remove
publishConfig: {private:true}frompackage.jsonfiles (pull request: chore: enable publishing of examples to npm #1283) - Publish the first version of all examples to npmjs
- Rework
lb4 exampleto fetch examples from npm using pacote library provided by npm, Inc.