Skip to content

chore: enable publishing of examples to npm #1283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bajtos merged 1 commit into from
Apr 26, 2018
Merged

chore: enable publishing of examples to npm #1283

bajtos merged 1 commit into from
Apr 26, 2018

Conversation

@bajtos
Copy link
Member

@bajtos bajtos commented Apr 26, 2018

This is the first step of reworking lb4 example to download example packages from npm instead of GitHub - see #1120

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

@bajtos bajtos added the feature label Apr 26, 2018
@bajtos bajtos added this to the April 2018 milestone Apr 26, 2018
@bajtos bajtos self-assigned this Apr 26, 2018
@bajtos bajtos requested review from raymondfeng and virkt25 April 26, 2018 06:02
@bajtos bajtos requested a review from b-admike as a code owner April 26, 2018 06:02
@virkt25 virkt25 mentioned this pull request Apr 26, 2018
Closed
3 tasks
@bajtos bajtos merged commit 104d3c2 into master Apr 26, 2018
@bajtos bajtos deleted the chore/publish-examples-to-npm branch April 26, 2018 14:37
@bajtos bajtos removed the review label Apr 26, 2018
@raymondfeng
Copy link
Contributor

raymondfeng commented Apr 26, 2018

I have published examples to npm registry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raymondfeng raymondfeng Awaiting requested review from raymondfeng raymondfeng is a code owner

3 more reviewers

@virkt25 virkt25 virkt25 approved these changes

@b-admike b-admike b-admike approved these changes

@shimks shimks shimks approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bajtos bajtos

Labels

feature

Projects

None yet

Milestone

April 2018

Development

Successfully merging this pull request may close these issues.

6 participants

@bajtos @raymondfeng @virkt25 @b-admike @shimks