test(cli): disable GitHub cloning tests #1003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virkt25
reviewed
Feb 15, 2018
| * being cloned properly, we can't hang that idea on validating the | ||
| * particular presence of any content that isn't perpetually required. | ||
| * | ||
| * I'm not sure how to update this test in a useful way without creating |
Contributor
There was a problem hiding this comment.
Maybe add a comment saying this test can be removed entirely once #932 is completed as that will test a project by running it, which should be adequate verification of cloneExampleFromGitHub
kjdelisle
force-pushed
the
cli/disable-clone-test
branch
from
6102676 to
4f9ef9d
Compare
virkt25
approved these changes
Feb 15, 2018
jannyHou
approved these changes
Feb 15, 2018
The check for equality on example packages after cloning prevents update of the contents of those packages, since they are no longer equivalent! As a result, we are disabling this test for now until we can come up with something that suitably validates the behaviour we expect, but in a way that doesn't prevent future changes from passing tests.
kjdelisle
force-pushed
the
cli/disable-clone-test
branch
from
4f9ef9d to
0132f4d
Compare
Contributor
Author
|
@b-admike Unfortunately, it seems to be the only test underneath that describe, so it's all disabled as a result. :( |
Contributor
Author
|
Not waiting on macOS to finish, since it passes locally on my mac, works everywhere else AND just happens to be disabling a test. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check for equality on example packages after cloning prevents
update of the contents of those packages, since they are no longer
equivalent! As a result, we are disabling this test for now until
we can come up with something that suitably validates the
behaviour we expect, but in a way that doesn't prevent future
changes from passing tests.
blocks #1001
Checklist
npm testpasses on your machinepackages/cliwere updatedpackages/example-*were updated