Skip to content

test(cli): disable GitHub cloning tests #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kjdelisle merged 1 commit into from
Feb 15, 2018
Merged

test(cli): disable GitHub cloning tests #1003

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion packages/cli/test/clone-example.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,23 @@ const VALID_EXAMPLE = 'getting-started';
const SANDBOX_PATH = path.resolve(__dirname, 'sandbox');
let sandbox;

describe('cloneExampleFromGitHub (SLOW)', function() {
describe.skip('cloneExampleFromGitHub (SLOW)', function() {
this.timeout(20000);
before(createSandbox);
beforeEach(resetSandbox);

/**
* FIXME(kjdelisle): This test will prevent any meaningful changes from
* landing in example repositories, since it will always fail the equality
* test provided when new files are added, or when existing files are
* removed as a part of refactor/cleanup.
*
* While I do value the idea of verifying that the example packages are
* being cloned properly, we can't hang that idea on validating the
* particular presence of any content that isn't perpetually required.
*
* This test can be removed once strongloop/loopback-next#932 is complete.
*/
it('extracts all project files', () => {
return cloneExampleFromGitHub(VALID_EXAMPLE, SANDBOX_PATH)
.then(outDir => {
Expand Down