Skip to content

Conversation

@bajtos
Copy link
Member

@bajtos bajtos commented Sep 17, 2019

This pull request is a follow-up for #3716 (comment).

While adding a missing test I found that we have a bug in the current implementation 🙈This pull requests adds the missing test and fixes the implementation too.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
@bajtos bajtos merged commit 34a2077 into master Sep 17, 2019
@bajtos bajtos deleted the test/relation-controller-newmodel branch September 17, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants