Skip to content

fix(cli): fix schema title for POST operation in relation controllers #3754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bajtos merged 1 commit into from
Sep 17, 2019
Merged

fix(cli): fix schema title for POST operation in relation controllers #3754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/generators/relation/templates/controller-relation-template-has-many.ts.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export class <%= controllerClassName %> {
content: {
'application/json': {
schema: getModelSchemaRef(<%= targetModelClassName %>, {
title: 'New <%= targetModelClassName %>In<%= sourceModelClassName %>',
title: 'New<%= targetModelClassName %>In<%= sourceModelClassName %>',
exclude: ['<%= targetModelPrimaryKey %>'],
optional: ['<%= foreignKeyName %>']
}),
Expand Down
5 changes: 4 additions & 1 deletion packages/cli/test/integration/generators/relation.has-many.integration.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ describe('lb4 relation HasMany', function() {
assert.file(expectedControllerFile);
});

it('controller with hasMany class and constractor', async () => {
it('controller with hasMany class and constructor', async () => {
const expectedControllerFile = path.join(
SANDBOX_PATH,
CONTROLLER_PATH,
Expand Down Expand Up @@ -525,6 +525,7 @@ describe('lb4 relation HasMany', function() {
/},\n . {2}},\n .}\)\n {2}async create\(\n/,
/\@param\.path\.number\('id'\) id: typeof Customer\.prototype\.id,\n/,
/\@requestBody\(\{\s+content: {\s+'application\/json': {\s+schema: getModelSchemaRef\(Order, {\n/,
/title: 'NewOrderInCustomer',\n/,
/exclude: \['id'\],\n/,
/optional: \['customerId'\]\n/,
/}\),\s+},\s+},\s+}\) order: Omit<Order, 'id'>,\n/,
Expand All @@ -538,6 +539,7 @@ describe('lb4 relation HasMany', function() {
/},\n . {2}},\n .}\)\n {2}async create\(\n/,
/\@param\.path\.number\('id'\) id: typeof CustomerClass\.prototype\.custNumber,\n/,
/\@requestBody\(\{\s+content: {\s+'application\/json': {\s+schema: getModelSchemaRef\(OrderClass, {\n/,
/title: 'NewOrderClassInCustomerClass',\n/,
/exclude: \['orderNumber'\],\n/,
/optional: \['customerClassCustNumber'\]\n/,
/}\),\s+},\s+},\s+}\) orderClass: Omit<OrderClass, 'orderNumber'>,\n/,
Expand All @@ -551,6 +553,7 @@ describe('lb4 relation HasMany', function() {
/},\n . {2}},\n .}\)\n {2}async create\(\n/,
/\@param\.path\.number\('id'\) id: typeof CustomerClassType\.prototype\.custNumber,\n/,
/\@requestBody\(\{\s+content: {\s+'application\/json': {\s+schema: getModelSchemaRef\(OrderClassType, {\n/,
/title: 'NewOrderClassTypeInCustomerClassType',\n/,
/exclude: \['orderString'\],\n/,
/optional: \['customerClassTypeCustNumber'\]\n/,
/}\),\s+},\s+},\s+}\) orderClassType: Omit<OrderClassType, 'orderString'>,\n/,
Expand Down