fix: remove restriction to Entities from DefaultKeyValueRepository #4996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeyValue repository does not require Entities, it can be used with any model. This was an intentional decision when implementing LB3 key-value APIs, to allow the key value to be provided outside of the data stored, thus enabling use cases like storing arbitrary data (including binary blobs) via the key-value API. Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
dougal83
approved these changes
Mar 30, 2020
raymondfeng
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KeyValue repository does not require Entities, it can be used with any model. This was an intentional decision when implementing LB3 key-value APIs, to allow the key value to be provided outside of the data stored, thus enabling use cases like storing arbitrary data (including binary blobs) via the key-value API.
I have extracted this pull request from #4949 to get it landed faster.
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈