Skip to content

fix: remove restriction to Entities from DefaultKeyValueRepository #4996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bajtos merged 1 commit into from
Mar 30, 2020
Merged

fix: remove restriction to Entities from DefaultKeyValueRepository #4996

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/repository/src/repositories/kv.repository.bridge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

import legacy from 'loopback-datasource-juggler';
import {DataObject, Options} from '../common-types';
import {Entity} from '../model';
import {Model} from '../model';
import {KeyValueFilter, KeyValueRepository} from './kv.repository';
import {ensurePromise, juggler} from './legacy-juggler-bridge';

Expand All @@ -22,7 +22,7 @@ if (!(Symbol as any).asyncIterator) {
/**
* An implementation of KeyValueRepository based on loopback-datasource-juggler
*/
export class DefaultKeyValueRepository<T extends Entity>
export class DefaultKeyValueRepository<T extends Model>
implements KeyValueRepository<T> {
/**
* A legacy KeyValueModel class
Expand All @@ -34,7 +34,7 @@ export class DefaultKeyValueRepository<T extends Entity>
* @param ds - Legacy DataSource
*/
constructor(
private entityClass: typeof Entity & {prototype: T},
private entityClass: typeof Model & {prototype: T},
ds: juggler.DataSource,
) {
// KVModel class is placeholder to receive methods from KeyValueAccessObject
Expand Down