feat: try passport login example with express middleware #5339

deepakrkris · 2020-05-05T15:52:06Z

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

npm test passes on your machine
New tests added or existing tests modified to cover all changes
Code conforms with the style guide
API Documentation in code was updated
Documentation in /docs/site was updated
Affected artifact templates in packages/cli were updated
Affected example projects in examples/* were updated

raymondfeng · 2020-05-05T19:37:59Z

examples/passport-login/src/authentication-strategies/types.ts

  return userProfile;
 };
+
+export class FacebookOauth implements Provider<GenericInterceptor<InvocationContext>> {


GenericInterceptor<InvocationContext> can be shorten as Interceptor.

raymondfeng · 2020-05-05T19:55:37Z

examples/passport-login/src/application.ts

+    this.bind('passport-facebook').toProvider(FacebookOauth);
+    this.bind('passport-google').toProvider(GoogleOauth);
+    this.bind('passport-oauth2').toProvider(CustomOauth2);
+


You can compose 5 interceptors into one (depending on #5343)

import {composeInterceptors} from '@loopback/context'; const authInterceptor = composeInterceptors( 'passport-init-mw', // or use `toInterceptor(passport.initialize())` directly without binding it 'passport-session-mw', // or use `toInterceptor(passport.session())` 'passport-facebook', 'passport-google', 'passport-oauth2'); // ... @intercept(authInterceptor)

perfect, thank you

raymondfeng · 2020-05-06T00:58:35Z

examples/passport-login/data/db.json

+      "1": "{\"name\":\"Deepak Rajamohan\",\"username\":\"deepak.r.kris@gmail.com\",\"email\":\"deepak.r.kris@gmail.com\",\"id\":1}"
    },
    "UserIdentity": {
+      "3463934540288186": "{\"id\":\"3463934540288186\",\"provider\":\"facebook\",\"profile\":{\"emails\":[{\"value\":\"deepak.r.kris@gmail.com\"}]},\"authScheme\":\"facebook\",\"created\":\"2020-05-06T00:48:12.355Z\",\"userId\":1}"


I remember that we had a discussion not to include db.json as the data change over time.

yes, I did include in the git ignore, not sure how this gets included every time, I will fix that as well.

i just removed the file altogether and its reference

raymondfeng · 2020-05-06T01:01:08Z

examples/passport-login/src/authentication-interceptors/types.ts

+ *      'passport-google',
+ *      'passport-oauth2'
+ */
+export function OAuth2InterceptExpressMiddleware() {


Maybe the name can be simpler as oauth2. This way, the decorator will be @oauth2

ok, but I have to simplify as well as be clear this is via interceptors middleware chain

I will try simplifying

jannyHou

👍 👍 Awesome improvement! LGTM and please make sure tests pass.

raymondfeng · 2020-05-06T23:13:18Z

examples/passport-login/src/authentication-interceptors/oauth2.ts

      // if provider name is given then use this middleware otherwise pass along
      if (request.query['oauth2-provider-name'] === 'oauth2') {
-        return toInterceptor(passport.authenticate('oauth2'))(
+        return toInterceptor(passport.authenticate('facebook'))(


Please move this function out as we don't want to call passport.authenticate multiple times.

In the code below, we probably should use return next(); instead of just next();.

raymondfeng · 2020-05-07T02:53:16Z

@deepakrkris Please run npm run prettier:fix to fix the issue - https://travis-ci.com/github/strongloop/loopback-next/jobs/329111814

raymondfeng · 2020-05-07T02:54:04Z

examples/passport-login/src/authentication-interceptors/facebook-interceptor.ts

@@ -0,0 +1,38 @@
+// Copyright IBM Corp. 2020. All Rights Reserved.


Nitpick: we typically name the file as facebook.interceptor.ts.

raymondfeng · 2020-05-07T02:54:51Z

examples/passport-login/src/authentication-interceptors/facebook-interceptor.ts

+  ExpressRequestHandler,
+} from '@loopback/rest';
+
+export class FacebookOauthInterceptor implements Provider<Interceptor> {


Let's mark it with @bind({scope: BindingScope.SINGLETON}).

raymondfeng

See my comment.

raymondfeng · 2020-05-07T07:12:17Z

examples/passport-login/src/application.ts

+    this.bind('passport-facebook').toProvider(FacebookOauthInterceptor);
+    this.bind('passport-google').toProvider(GoogleOauthInterceptor);
+    this.bind('passport-oauth2').toProvider(CustomOauth2Interceptor);
+    this.bind('set-session-user').toProvider(SessionAuth);


We should be able to make these interceptor providers singleton too.

deepakrkris requested a review from emonddr as a code owner May 5, 2020 15:52

deepakrkris mentioned this pull request May 5, 2020

[SPIKE] DO NOT MERGE feat: try mw with passport login example #5302

Closed

7 tasks

deepakrkris force-pushed the passport-login-interceptor branch from dbd8733 to b8f4da6 Compare May 5, 2020 19:34

deepakrkris requested review from jannyHou and raymondfeng May 5, 2020 19:35

raymondfeng reviewed May 5, 2020

View reviewed changes

deepakrkris force-pushed the passport-login-interceptor branch 5 times, most recently from 0f3f486 to baafe2c Compare May 6, 2020 00:50

raymondfeng reviewed May 6, 2020

View reviewed changes

deepakrkris force-pushed the passport-login-interceptor branch 2 times, most recently from 14482a7 to 9ca3f83 Compare May 6, 2020 01:13

raymondfeng approved these changes May 6, 2020

View reviewed changes

jannyHou approved these changes May 6, 2020

View reviewed changes

raymondfeng reviewed May 6, 2020

View reviewed changes

deepakrkris force-pushed the passport-login-interceptor branch 2 times, most recently from b5ae95d to 1ba52ea Compare May 7, 2020 01:37

raymondfeng reviewed May 7, 2020

View reviewed changes

raymondfeng mentioned this pull request May 7, 2020

feat(context): force interceptor functions to return a value #5357

Merged

7 tasks

deepakrkris force-pushed the passport-login-interceptor branch from 1ba52ea to f81a1e3 Compare May 7, 2020 07:02

raymondfeng reviewed May 7, 2020

View reviewed changes

feat: try mw with passport login example

5402e37

deepakrkris force-pushed the passport-login-interceptor branch from f81a1e3 to 5402e37 Compare May 7, 2020 07:25

emonddr approved these changes May 7, 2020

View reviewed changes

deepakrkris merged commit b5c5ab7 into master May 7, 2020

deepakrkris deleted the passport-login-interceptor branch May 7, 2020 15:54

		@@ -0,0 +1,38 @@
		// Copyright IBM Corp. 2020. All Rights Reserved.

feat: try passport login example with express middleware #5339

feat: try passport login example with express middleware #5339

Uh oh!

Conversation

deepakrkris commented May 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jannyHou left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

raymondfeng commented May 7, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

raymondfeng left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

deepakrkris commented May 5, 2020 •

edited

Loading