Skip to content

fix(context): allow binding keys to be used with composeInterceptors() #5343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
raymondfeng merged 1 commit into from
May 5, 2020
Merged

fix(context): allow binding keys to be used with composeInterceptors() #5343

raymondfeng merged 1 commit into from
May 5, 2020

Conversation

@raymondfeng
Copy link
Contributor

@raymondfeng raymondfeng commented May 5, 2020 •
edited
Loading

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@raymondfeng raymondfeng mentioned this pull request May 5, 2020
Merged
7 tasks
@raymondfeng raymondfeng merged commit 0663c04 into master May 5, 2020
@raymondfeng raymondfeng deleted the compose-interceptors branch May 5, 2020 20:36
deepakrkris
deepakrkris reviewed May 5, 2020
View reviewed changes
Copy link
Contributor

@deepakrkris deepakrkris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@deepakrkris deepakrkris deepakrkris left review comments

@emonddr emonddr emonddr approved these changes

@jannyHou jannyHou jannyHou approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@raymondfeng @emonddr @deepakrkris @jannyHou