feat(cli): bind model classes during boot #5378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondfeng
requested review from
agnes512,
hacksparrow and
jannyHou
as code owners
achrinza
requested changes
May 9, 2020
bajtos
reviewed
May 11, 2020
This is useful for context inspection to know what model classes are in an application.
|
I need it in my project that I use, please review it as soon as you can thanks! :) |
hacksparrow
reviewed
May 13, 2020
hacksparrow
approved these changes
May 13, 2020
Contributor
hacksparrow
left a comment
hacksparrow
left a comment
There was a problem hiding this comment.
Apart from that debug message, it LGTM.
bajtos
reviewed
May 14, 2020
|
|
||
| debug('Bind class: %s', cls.name); | ||
| // We are binding the model class itself | ||
| const binding = this.app.bind(`models.${cls.name}`).to(cls).tag('model'); |
Member
There was a problem hiding this comment.
@raymondfeng can you please extract the code building the binding to a standalone function that can be used to bind models manually, in cases where @loopback/boot is not involved? For example in extensions.
const binding = createModelClassBinding(cls);
app.add(binding);Similar helpers we already have: createComponentApplicationBooterBinding, createBindingFromClass, createBodyParserBinding, createServiceBinding.
raymondfeng
added a commit
that referenced
this pull request
May 14, 2020
7 tasks
raymondfeng
added a commit
that referenced
this pull request
May 15, 2020
raymondfeng
added a commit
that referenced
this pull request
May 15, 2020
raymondfeng
added a commit
that referenced
this pull request
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈