feat(boot): add more helper methods for model and application booters #5432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondfeng
changed the title
applicationBooter method to BootMixin
bajtos
approved these changes
May 15, 2020
Member
bajtos
left a comment
bajtos
left a comment
There was a problem hiding this comment.
Thank you for converting my suggestions into a pull request!
The changes look mostly good to me, please get the final approval from code owners.
| constructor() { | ||
| super(); | ||
| this.projectRoot = __dirname; | ||
| this.applicationBooter(app); |
Member
There was a problem hiding this comment.
Should the method name start with a verb, e.g. this.addApplicationBooter?
Contributor
Author
There was a problem hiding this comment.
Again, I choose a noun to be consistent with other methods.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This further simplifies how a main application can boot sub-applications. The idea was from @bajtos in one of the comments (I cannot find it anymore :-).
Add
model()toRepositoryMixinand use it for model booter (feat(cli): bind model classes during boot #5378 (comment))Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈