Add JWT authentication example #5463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
reviewed
May 18, 2020
bajtos
reviewed
May 18, 2020
dhmlau
force-pushed
the
auth-example
branch
3 times, most recently
from
e2d4f73 to
07b10e1
Compare
jannyHou
reviewed
May 21, 2020
jannyHou
reviewed
May 21, 2020
Contributor
jannyHou
left a comment
jannyHou
left a comment
There was a problem hiding this comment.
@dhmlau The lint error is caused by local eslint plugin conflicts with the global one.
I solved it on local by:
- git clone a fresh lb-next repo
- remove the 4 dev dependencies I marked in the package.json file
npm ito reinstall the dependencies, the package-lock.json file will also update- then
npm run lint:fix
I tried npm run start in the example repo but seems the app doesn't start, it's caused by the index.js file. It doesn't run the main function.
I updated my changes in branch https://github.com/strongloop/loopback-next/tree/jwt-example-update, feel free to merge it or use the code there. The app runs on my local and lint passes
Member
Author
jannyHou
reviewed
May 22, 2020
| type: 'string', | ||
| required: true, | ||
| }) | ||
| password: string; |
Contributor
There was a problem hiding this comment.
The password should have json property minLength: 8 as well to make sure the new user has valid password
jannyHou
reviewed
May 22, 2020
Contributor
jannyHou
left a comment
jannyHou
left a comment
There was a problem hiding this comment.
👍Tested on local the app works well, LGTM a few nitpicks.
jannyHou
approved these changes
May 22, 2020
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #5421, I think it might be better to have an example app, so that the tutorial can point to the source code.
What's left: CLI, add this example to Examples.md, and CODEOWNERS file.
Related to: #5421
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈