-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix: jwt auth tutorial #5421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: jwt auth tutorial #5421
Conversation
jannyHou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙇 Thank you @dhmlau. The plan and the new doc is awesome, every part looks good to me. I think you can turn this PR to be a formal one.
|
@jannyHou, thanks. Let me clean it up a bit before making it available for review. |
jannyHou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments for the code changes after creating the spec enhancer. Verified the steps with todo-jwt example, all are good 👍
jannyHou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
From the feedback we got in loopbackio/loopback.io#911, I think it would be good if we simply the tutorial. Now that we have the
@loopback/authentication-jwtextension, I think it's a good time for us to do it now. While learning how to use the extension, I've created this article (https://medium.com/@MobileDiana/add-jwt-authentication-in-your-loopback-4-application-325137642c2c) and this repo: https://github.com/dhmlau/loopback4-example-todo-jwt.My plan is:
@jannyHou @deepakrkris, what do you think? Do we have an example using the new jwt extension?
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈