Skip to content

Conversation

@dhmlau
Copy link
Member

@dhmlau dhmlau commented May 14, 2020

From the feedback we got in loopbackio/loopback.io#911, I think it would be good if we simply the tutorial. Now that we have the @loopback/authentication-jwt extension, I think it's a good time for us to do it now. While learning how to use the extension, I've created this article (https://medium.com/@MobileDiana/add-jwt-authentication-in-your-loopback-4-application-325137642c2c) and this repo: https://github.com/dhmlau/loopback4-example-todo-jwt.

My plan is:

@jannyHou @deepakrkris, what do you think? Do we have an example using the new jwt extension?

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

Copy link
Contributor

@jannyHou jannyHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇 Thank you @dhmlau. The plan and the new doc is awesome, every part looks good to me. I think you can turn this PR to be a formal one.

@dhmlau
Copy link
Member Author

dhmlau commented May 16, 2020

@jannyHou, thanks. Let me clean it up a bit before making it available for review.

Copy link
Contributor

@jannyHou jannyHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments for the code changes after creating the spec enhancer. Verified the steps with todo-jwt example, all are good 👍

Copy link
Contributor

@jannyHou jannyHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dhmlau dhmlau merged commit c30086c into master May 28, 2020
@dhmlau dhmlau deleted the auth-tutorial branch May 28, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants