Skip to content

Conversation

@dhmlau
Copy link
Member

@dhmlau dhmlau commented May 14, 2020

I'd like to do some rework in the original JWT authentication tutorial which is based on the shopping example. Since it has lots of great content in it, I'd like to preserve it in this repo.

This PR copies the tutorial https://loopback.io/doc/en/lb4/Authentication-Tutorial.html. The only change is to fix the links since the location has changed.

cc @jannyHou @deepakrkris

Comment on lines +1246 to +1252
this.api({
openapi: '3.0.0',
info: {title: pkg.name, version: pkg.version},
paths: {},
components: {securitySchemes: SECURITY_SCHEME_SPEC},
servers: [{url: '/'}],
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may be able to simplify this part. (see https://github.com/strongloop/loopback4-example-shopping/blob/master/packages/shopping/src/application.ts). In built enhancer in place now. 👍

Copy link
Contributor

@dougal83 dougal83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, you've done very well writing this all up comprehensively. So much content it may warrant a TOC/jump to nav. at the start?

@dhmlau
Copy link
Member Author

dhmlau commented May 16, 2020

@dougal83, the content is actually written by @emonddr. :) You reminded me that I should add @emonddr's authorship in this commit. I'm in the middle of simplifying the JWT auth tutorial but the original content, as you said, contains lots of useful information, so I'd like to preserve it in here and see what we can put back in other parts of the documentation.

See PR loopbackio/loopback-next#5421.

Signed-off-by: Diana Lau <dhmlau@ca.ibm.com>
@dhmlau dhmlau force-pushed the auth-tutorial branch 2 times, most recently from 6d1239a to 451eb48 Compare August 18, 2020 15:00
@dhmlau
Copy link
Member Author

dhmlau commented Oct 19, 2020

We've done some work in improving the authentication documentation. After discussing with @jannyHou, we think this PR is good to close.

@dhmlau dhmlau closed this Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants