fix: monorepo, package metadata scripts' filepath on Windows #6175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achrinza
added
bug
Internal Tooling
4 tasks
raymondfeng
reviewed
Aug 24, 2020
bin/check-package-metadata.js
Outdated
|
|
||
| for (const p of packages) { | ||
| const packagePath = path.relative(rootPath, p.location); | ||
| const packagePath = path.relative(rootPath, p.location).replace('\\', '/'); |
Contributor
There was a problem hiding this comment.
Please note that .replace('\\', '/'); only replaces the first occurrence of \:
'x\\y\\zz'.replace('\\', '/') => 'x/y\\zz'
Contributor
There was a problem hiding this comment.
Let's use .replace(/\\/g, '/') instead.
raymondfeng
requested changes
Aug 24, 2020
Contributor
raymondfeng
left a comment
raymondfeng
left a comment
There was a problem hiding this comment.
Please fix the replace issue.
achrinza
force-pushed
the
feat/fixes-monorepo-update-filepath
branch
from
382e005 to
871e5d7
Compare
achrinza
force-pushed
the
feat/fixes-monorepo-update-filepath
branch
from
871e5d7 to
0d1e77e
Compare
raymondfeng
reviewed
Aug 24, 2020
tsconfig.json
Outdated
| }, | ||
| { | ||
| "path": "extensions/waterline/tsconfig.json" | ||
| }, |
Contributor
There was a problem hiding this comment.
Please revert this change.
Signed-off-by: Rifa Achrinza <25147899+achrinza@users.noreply.github.com>
achrinza
force-pushed
the
feat/fixes-monorepo-update-filepath
branch
from
0d1e77e to
f262868
Compare
raymondfeng
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: #6155 (comment)
Signed-off-by: Rifa Achrinza 25147899+achrinza@users.noreply.github.com
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈