Skip to content

fix: monorepo, package metadata scripts' filepath on Windows #6175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raymondfeng merged 1 commit into from
Aug 24, 2020
Merged

fix: monorepo, package metadata scripts' filepath on Windows #6175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bin/check-package-metadata.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ async function checkMonorepoFile(packages, rootPath) {
const monorepoFile = await fs.readFile('docs/site/MONOREPO.md', 'utf8');

for (const p of packages) {
const packagePath = path.relative(rootPath, p.location);
const packagePath = path.relative(rootPath, p.location).replace(/\\/g, '/');

const packageExists =
monorepoFile.includes(p.name) || monorepoFile.includes(packagePath);
Expand Down Expand Up @@ -73,7 +73,7 @@ async function checkCodeOwnersFile(packages, rootPath) {
continue;
}

const packagePath = path.relative(rootPath, p.location);
const packagePath = path.relative(rootPath, p.location).replace(/\\/g, '/');

if (!codeOwnersFile.includes(packagePath)) {
errors.push(`${p.name} is not added in the CODEOWNERS.md file`);
Expand Down
2 changes: 1 addition & 1 deletion bin/update-monorepo-file.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const MONOREPO_FILE_DIST = 'docs/site';
const MONOREPO_FILE_NAME = 'MONOREPO.md';

function getPackageRelativeUri(pkg) {
return path.relative(pkg.rootPath, pkg.location);
return path.relative(pkg.rootPath, pkg.location).replace(/\\/g, '/');
}

async function getSortedPackages() {
Expand Down