fix: fix build break and upgrade dependencies #853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
bajtos
suggested changes
Jan 11, 2018
| "experimentalDecorators": true, | ||
| "noImplicitAny": true, | ||
| "strictNullChecks": true, | ||
|
|
Member
There was a problem hiding this comment.
JSON files should not be linted by prettier. I find this empty line as very useful to delimit language-related flags from project-related settings.
Could you please revert this change?
| "no-unused-variable": true, | ||
| "no-var-keyword": true, | ||
| "triple-equals": [true, "allow-null-check", "allow-undefined-check"], | ||
| "typeof-compare": true |
Member
There was a problem hiding this comment.
Could you please explain why you are removing typeof-compare? I am sure you have good reasons, I'd just like to understand them too 😄
Contributor
Author
There was a problem hiding this comment.
Running the upgraded version of tslint complains that typeof-compare rule is now the default since TS 2.2 and it's not needed.
Contributor
There was a problem hiding this comment.
^^^ It even prints that warning in our CI after tests pass (Travis & AppVeyor)
- fix build break by newer version of prettier - upgrade tool dependencies - remove the typeof-compare tslint rule as it's default now since TS 2.2
raymondfeng
force-pushed
the
fix-build
branch
from
4971a6f to
7b26106
Compare
Contributor
Author
|
@bajtos PTAL |
virkt25
approved these changes
Jan 11, 2018
shimks
approved these changes
Jan 11, 2018
b-admike
approved these changes
Jan 11, 2018
kjdelisle
approved these changes
Jan 11, 2018
jannyHou
approved these changes
Jan 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpasses on your machinepackages/cliwere updatedpackages/example-*were updated