Skip to content

fix: fix build break and upgrade dependencies #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raymondfeng merged 1 commit into from
Jan 11, 2018
Merged

fix: fix build break and upgrade dependencies #853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/build/bin/run-prettier.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ function run(argv, dryRun) {
}
args.push(...prettierOpts);

return utils.runCLI('prettier/bin/prettier', args, dryRun);
return utils.runCLI('prettier/bin-prettier', args, dryRun);
}

module.exports = run;
Expand Down
3 changes: 1 addition & 2 deletions packages/build/config/tslint.common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
"no-unused-expression": true,
"no-unused-variable": true,
"no-var-keyword": true,
"triple-equals": [true, "allow-null-check", "allow-undefined-check"],
"typeof-compare": true
Copy link
Member

@bajtos bajtos Jan 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explain why you are removing typeof-compare? I am sure you have good reasons, I'd just like to understand them too 😄

Copy link
Contributor Author

@raymondfeng raymondfeng Jan 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running the upgraded version of tslint complains that typeof-compare rule is now the default since TS 2.2 and it's not needed.

Copy link
Contributor

@kjdelisle kjdelisle Jan 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^^^ It even prints that warning in our CI after tests pass (Travis & AppVeyor)

"triple-equals": [true, "allow-null-check", "allow-undefined-check"]
}
}
12 changes: 6 additions & 6 deletions packages/build/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@
"license": "MIT",
"dependencies": {
"@types/mocha": "^2.2.43",
"@types/node": "^8.0.50",
"@types/node": "^8.5.8",
"cross-spawn": "^5.1.0",
"debug": "^3.1.0",
"mocha": "^4.0.0",
"nyc": "^11.3.0",
"prettier": "^1.8.1",
"nyc": "^11.4.1",
"prettier": "^1.10.2",
"strong-docs": "^1.6.0",
"tslint": "^5.7.0",
"typescript": "^2.5.3"
"tslint": "^5.9.1",
"typescript": "^2.6.2"
},
"bin": {
"lb-tsc": "./bin/compile-package.js",
Expand All @@ -43,6 +43,6 @@
"posttest": "npm run lint"
},
"devDependencies": {
"fs-extra": "^4.0.2"
"fs-extra": "^5.0.0"
}
}