-
Notifications
You must be signed in to change notification settings - Fork 1.1k
chore: move tasks from prepare to prepublishOnly #928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
With this PR, an incremental A brand new |
virkt25
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing performance improvements!! Great job! 👍
Just a question ... is it possible for apidocs to ever end up in a state where it may break? If so ... should we be testing that with each PR or not? (I'm ok to skip testing it as long as it won't lead to other issues down the road).
.travis.yml
Outdated
|
|
||
| script: | ||
| - npm run test:ci | ||
| - npm run test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
script: and -npm run test can be removed in it's entirety as that's the default for travis. It was only added because we were running npm run test:ci.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Even though npm run test is the same as npm test, I prefer to use npm test.
appveyor.yml
Outdated
| - node --version | ||
| - npm --version | ||
| - npm run test:ci | ||
| - npm run test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this originally used to be just npm test.
The current build has 'prepare' for each package to: 1. Run tsc for dist 2. Run tsc for dist6 3. Run apidocs generation Neither 2 or 3 is required for most of our development tasks. Both steps are pretty time-consuming. Please note `prepare` is triggered with `npm install`, which is also part of `erna bootstrap`. This move will: 1. Speed up our scripts for most cases 2. Continue to ensure dist/dist6 builds and apidocs before publish
9080c5c to
9e9095e
Compare
In most cases, apidocs should not break as long as We can configure CI to run |
virkt25
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok to not test apidocs on CI personally unless we start running into issues down the road.
bajtos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM.
I wanted to comment on the fact that prepublishOnly is not available in Node.js 6.x, therefore publishing new releases while running Node.js 6.x will most likely produce broken packages (I didn't try to verify this from obvious reasons). However, prepare was added at the same time as prepublishOnly , therefore the change in this pull request is not making the current state any worse AFAICT.
|
CI failed on AppVeyor with a cryptic error (see the log), I have triggered a rebuild. |
|
@raymondfeng I landed this patch myself so that I can follow the new style in the example projects I am bringing to the monorepo. Thank you for reducing the wait times we are encountering during development! |
The current build has 'prepare' for each package to:
Neither 2 or 3 is required for most of our development tasks. Both steps
are pretty time-consuming.
Please note
prepareis triggered withnpm install, which is also partof
erna bootstrap.This move will:
Checklist
npm testpasses on your machinepackages/cliwere updatedpackages/example-*were updated