Skip to content

Conversation

@bajtos
Copy link
Member

@bajtos bajtos commented Jan 30, 2018

This reverts commit afac0cf
(pull request #928) as an experimental attempt to fix our failing build.

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Related API Documentation was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in packages/example-* were updated

This reverts commit afac0cf
(pull request #928) as an experimental attempt to fix our failing build.
@virkt25
Copy link
Contributor

virkt25 commented Jan 30, 2018

Use revert type for commit message instead of chore: revert.
Will review once builds pass.

@bajtos
Copy link
Member Author

bajtos commented Jan 30, 2018

For the record, I am experiencing a weird build failure in #933. I thought it was unrelated to those changes, but since #924 is passing the build on Travis CI, I am almost sure the problem is not on master but in my pull request adding microservices example.

I am closing this pull request for now.

@bajtos bajtos closed this Jan 30, 2018
@bajtos bajtos deleted the fix-ci-builds branch January 30, 2018 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants