Skip to content

Update to Babel 7.x#305

Merged
lukeed merged 3 commits into
lukeed:babelfrom
benedyktdryl:chore/babel-7x-upgrade
Jul 11, 2019
Merged

Update to Babel 7.x#305
lukeed merged 3 commits into
lukeed:babelfrom
benedyktdryl:chore/babel-7x-upgrade

Conversation

@benedyktdryl
Copy link
Copy Markdown

Hi,

This is my very firs PR which includes Babel 7.x related updates. Please let me know if you will be interested in such contribution so I can make further updates in that matter.

@lukeed
Copy link
Copy Markdown
Owner

lukeed commented Dec 8, 2017

Hey, very cool. Thanks!

Do you think Babel 7 is stable enough to use in production? I see that it's still beta & I know personally that they want more people to test 7 before it's an official release.

I think this is the case, correct me if I'm wrong~! But if so, we should hold off on Babel 7 until it's out of beta. We'll accept this PR when that time comes 😃

@benedyktdryl
Copy link
Copy Markdown
Author

Cool - I know it's beta. I made this branch for other guys so they can try to link this version if needed. I will keep eyes on this and go back when it will be more production ready.

@lukeed
Copy link
Copy Markdown
Owner

lukeed commented Dec 8, 2017

Great, thanks!

@hzlmn
Copy link
Copy Markdown
Collaborator

hzlmn commented Dec 8, 2017

@lukeed maybe we can publish it under beta tag? Would like to give it a try and do not want manually fetch from git repo 🐵

@benedyktdryl
Copy link
Copy Markdown
Author

I also want to ask for release it under beta tag as it will be easier to test it and also - it would help me a lot to maintain this PR:

vercel/next.js#3428

@lukeed
Copy link
Copy Markdown
Owner

lukeed commented Dec 13, 2017

I'm going to be releasing this as a next tag, along with some changes to the Taskr itself under a next tag.

I'll come back here shortly when that's prepped!

@timneutkens
Copy link
Copy Markdown

@lukeed could you release this as next? We're planning to move Next.js to babel 7 soon.

@lukeed
Copy link
Copy Markdown
Owner

lukeed commented Mar 23, 2018

Sure, tbh I forgot about this. I've been messing with Taskr core locally at one point and was hoping it publish it all under the next or beta tag

@timneutkens
Copy link
Copy Markdown

Thanks! Only this would be fine, don't want to fork and release our own version to test 😄

@timneutkens
Copy link
Copy Markdown

Just tried it out locally and the PR seems to work well 👍

@timneutkens
Copy link
Copy Markdown

@lukeed if you could release it that'd be awesome, it's the only thing holding back the tests in my PR 😄

@lukeed
Copy link
Copy Markdown
Owner

lukeed commented Mar 24, 2018

Do any of the beta deps need to be updated?

@timneutkens
Copy link
Copy Markdown

yeah looks like they need to be upgraded to the latest beta, which I believe is .42

@lukeed
Copy link
Copy Markdown
Owner

lukeed commented Mar 24, 2018

This is now available as @taskr/babel@next 🎉

I will merge when I'm ready to make the remaining Taskr changes. Thank you all & sorry for the untimely delay(s)~!

@timneutkens
Copy link
Copy Markdown

Nice! Thanks Luke 🙏

@lukeed lukeed changed the base branch from master to babel July 11, 2019 21:10
@lukeed
Copy link
Copy Markdown
Owner

lukeed commented Jul 11, 2019

Moving this into a separate babel branch since it's still under a next tag release. The request from #315 should also be applied to this (new) branch, moving this @taskr/babel@next off the beta version.

Thanks!

@lukeed lukeed merged commit 12c9bb3 into lukeed:babel Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants