Update to Babel 7.x - WIP#3428
Closed
benedyktdryl wants to merge 2 commits into
Closed
Conversation
przemyslaw-rzasa
approved these changes
Dec 9, 2017
This was referenced Dec 11, 2017
haohcraft
reviewed
Feb 26, 2018
| "@babel/runtime": "7.0.0-beta.32", | ||
| "@babel/template": "7.0.0-beta.32", | ||
| "ansi-html": "0.0.7", | ||
| "babel-core": "6.26.0", |
There was a problem hiding this comment.
Looks like this is still using babel-core.
There was a problem hiding this comment.
You will need to change it @babel/core, but in general you should rely on Babel's internals.
We already had a few discussions to expose the config to plugins authors babel/babel#7259.
Contributor
There was a problem hiding this comment.
If that PR gets merged we'll change to it.
|
Hope this PR will get merged soon. |
Contributor
|
It's on my list for Next v6. There's a few modules completely breaking down on babel 7. Will close this since I have a WIP locally. |
|
@timneutkens could you address my concern #3428 (comment)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This is my very firs PR which includes Babel 7.x related updates. Please let me know if you will be interested in such contribution so I can make further updates in that matter.
This PR is also related to those PRs.
I know it has conflict but I don't know if you're accepting such contributions or you want to put some updates to Babel packages so I made this PR to ask first, before any further work.