Switch to Typescript incrementally (test runs ts-node)#9535
Conversation
|
And there we have a problem with ts/babel - imports again. @pelotom thoughts on getting around this with babel for compilation? Perhaps there are other options than https://www.typescriptlang.org/docs/handbook/modules.html#export--and-import--require I filed babel/babel#7062 but I think we'll likely need to use tsc to process to es2015 first. |
|
The prettier issue is fixed - I didn't change the parser. |
|
Note - I have a potential fix for |
|
|
|
We are just a bit closer. |
| rippleVisible: { | ||
| opacity: 0.2, | ||
| }, | ||
| export const styles: StyleRulesCallback<TouchRippleClassKey> = (theme: Theme) => ({ |
There was a problem hiding this comment.
FYI, you don’t need the : Theme annotation since you declared the overall type of styles.
|
It looks like next.js added I assume next.js would need to be using babel 7 first (this babel 7 PR has gone uncommented vercel/next.js#3428). And if using babel 7, then there doesn't seem to be any reason why |
|
Closing in favor of #9561. If we want to go back to using ts-node, I'll have to re-apply those changes there. |
Supersedes #9517. See #9517 for details.
What's left
Completed
yarn build runs- updated to babel 7. Effectively, we usetsclike we didflow, andtscis uninvolved in the build process (but a required precursor).