Add .jsx extension support#3376
Merged
timneutkens merged 23 commits intoDec 5, 2017
Merged
Conversation
arunoda
suggested changes
Dec 3, 2017
| @@ -0,0 +1,3 @@ | |||
| export const World = () => ( | |||
Contributor
There was a problem hiding this comment.
The filepath for this test contains custom-extensions text. Since this is just JSX, it'd simply write a testcase in the basictest cases.
* examples: add create-next-app * fix with-typescript readme
…l#3337) For upgrading I used flow-upgrade module by https://yarnpkg.com/en/package/flow-upgrade
2 changes: `passHref` - just added a cautionary note on the importance of `passHref`. We had a few days of no-href links on our site b/c we used a custom component instead of a raw `<a>` tag, and Google bot wasn't crawling our links (confirmed in Google cache). Hurt our SEO a bit, so I thought it was worth noting. `useFileSystemPublicRoutes` - this is mentioned in vercel#914 , but it doesn't appear any doc was actually added. We use `next-routes`, and we were serving all the files in `/pages/` in addition to their route patterns (ie duplicate content), which can be a pain w/ SEO and duplicate content.
* Pulled encoding to top of head (vercel#3214) * Remove next.d.ts to use @types/next (vercel#3297) * Add with-mobx-state-tree example (vercel#3179) * Adapt with-mobx example for with-mobx-state-tree * Remove unnecessary lastUpdate parameter to show off snapshot * update readme * make other.js more closely mimic index.js * Upgrade styled-jsx to v2.2.1 Includes some bug fixes. * Fix linting
arunoda
suggested changes
Dec 4, 2017
| @@ -0,0 +1,14 @@ | |||
| module.exports = function ({types}) { | |||
Contributor
There was a problem hiding this comment.
Add a comment with what this plugin does. May be we need a better name for the plugin. transform seems like too generic.
|
|
||
| const query = loaderUtils.getOptions(this) | ||
|
|
||
| if (query.validateFile) { |
Contributor
There was a problem hiding this comment.
Add a comment about how this validateFile method comes here.
| if (i[i.length - 1] === sep) { | ||
| return [ | ||
| i + 'index.js', | ||
| i + 'index.jsx', |
Contributor
Author
There was a problem hiding this comment.
It's used by the ondemandentries plugin to resolve the file within webpack. That's why it's needed here.
Contributor
Author
There was a problem hiding this comment.
next build -> next start etc work fine without this.
| @@ -0,0 +1,4 @@ | |||
| import {World} from '../components/world' | |||
Contributor
There was a problem hiding this comment.
Add another case where we are importing with ../components/world.jsx
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements part of #2391
Fixes #200
What it does
Allows components to be created with the
.jsxextension.How it works
On the webpack side we define .jsx to be resolved. And emit-file-loader will emit files ending in .jsx as .js. So inside of
.nextthere will only be.jsfiles.On the server side we make sure
.jsxis removed from import statements using a babel plugin. So you can doimport Hello from '../components/hello.jsx. This is done because Node.js doesn't know how to resolve.jsx.