Skip to content

Update to Babel 7.x#362

Closed
benedyktdryl wants to merge 2 commits into
vercel:masterfrom
benedyktdryl:chore/babel-7x-upgrade
Closed

Update to Babel 7.x#362
benedyktdryl wants to merge 2 commits into
vercel:masterfrom
benedyktdryl:chore/babel-7x-upgrade

Conversation

@benedyktdryl
Copy link
Copy Markdown

Hi,

This is my very firs PR which includes Babel 7.x related updates. Please let me know if you will be interested in such contribution so I can make further updates in that matter.

@giuseppeg
Copy link
Copy Markdown
Collaborator

@benedyktdryl thanks! why not..

@benedyktdryl
Copy link
Copy Markdown
Author

Thanks. Question: is there any chance this can be released under some beta tag? If yes, it will be easier to maintain changes in Next.js related PR:

vercel/next.js#3428

@giuseppeg
Copy link
Copy Markdown
Collaborator

Oh sorry I forgot we had babel related dependencies. That is going to be an issue for the ones who don't use Babel 7 yet right? If that's the case maybe we can wait a bit or if Next.js needs styled-jsx to be on Babel 7 then we could release a separate, temporary version. Maybe dist-tag it with babel7

@benedyktdryl
Copy link
Copy Markdown
Author

Indeed there will be an issue, an dist-tag is good idea, thanks.

@giuseppeg
Copy link
Copy Markdown
Collaborator

will reconsider this when Babel 6 is deprecated or we find a better way to guarantee backwards compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants