Fix tmenu in MacVim and submenu handling in Touch Bar #1086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix `tmenu` to work when it's called after the menu has already been created, by implementing `gui_mch_menu_set_tip`. This works for menus, tool bar, and Touch Bar (see macvim-dev#1084 which added tmenu support for TouchBar). Also, fix Touch Bar's submenu handling to reuse more common shared function. Previously enabling/disabling/removing Touch Bar submenu items didn't work as it had a hard-coded length check.
ychin
changed the title
ychin
referenced
this pull request
Sep 14, 2020
- Add the declaration for gui_mch_menu_set_tip in proto - On prior to 10.12 comment out the declarations of touchbar methods
ychin
added
UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
tmenuto work when it's called after the menu has already been created, by implementinggui_mch_menu_set_tip. This works for menus, tool bar, and Touch Bar (see #1084 which added tmenu support for TouchBar).Also, fix Touch Bar's submenu handling to reuse more common shared function. Previously enabling/disabling/removing Touch Bar submenu items didn't work as it had a hard-coded length check.