Add extern_methods! macro#217
Merged
Merged
Conversation
Owner
Author
|
I've explicitly used it as: extern_methods!(
...
);Since that allows rustfmt to format the macro contents. |
c73de13 to
df5ba6b
Compare
3 tasks
Owner
Author
|
I'm a bit unsure of how big of an improvement this really is. While it is more succinct, error messages get a lot worse, I did find a bug by converting things to use this: EDIT: With #239 this becomes much more useful, and there's a nice symmetry between this and |
Just a simple manual wrapping; we don't use the macro's functionality yet!
65e38bb to
7945310
Compare
7945310 to
b86c94b
Compare
b86c94b to
3f1e53f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #161.
Syntax:
TODO:
Find a way to allow usingmsg_send_idandmsg_send_bool- should be done in a way thatdeclare_class!also supports such things!boolhandling #239 for themsg_send_boolsituation. Will be making a#[sel_id(...)]attribute, but that is much easier to do with this merged