Proper bool handling#239
Merged
Merged
Conversation
madsmtm
added
enhancement
|
This is awesome! |
This was referenced Aug 16, 2022
Merged
madsmtm
force-pushed
the
bool-handling
branch
4 times, most recently
from
6f724af to
4c633d3
Compare
madsmtm
force-pushed
the
bool-handling
branch
3 times, most recently
from
ecfb88c to
b2d67cf
Compare
madsmtm
added a commit
to madsmtm/cacao
that referenced
this pull request
Sep 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4 real this time: Automatic conversion of
boolto/from the Objective-CBOOLacross message sends.Yes, it's unclean, and yes, it couples
objc2-encodeto the runtime (which it will have to be anyhow to handle bitfields properly), and feels like a lot of work for a little thing, but it's simply just a huge productivity boost to never again have to worry aboutboolbeing special!Unblocks #217, with this it suddenly becomes much more useful!
Original idea in #126, dismissed back then because of complexity.
Random notes to myself:
extern "C" fn(bool)inadd_method(EncodeArguments)boolinIvarcfgguard the stuff inobjc2-encodeandobjc-sysproperly