Skip to content

[MARLIN-882] Enable S3 Signature Version 4 for aws #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ouranos merged 1 commit into from
May 22, 2019
Merged

[MARLIN-882] Enable S3 Signature Version 4 for aws #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions shared/docker-entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ elif [ -n "$S3_URI" ]; then
if [ -z "$S3_SECRET_ACCESS_KEY" ]; then
opts="--no-sign-request"
fi
# Setting Signature Version 4 for S3 Request Authentication
aws configure set s3.signature_version s3v4
Copy link
Copy Markdown

@adamaziz15 adamaziz15 May 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be aws configure set default.s3.signature_version s3v4? Took this from https://docs.aws.amazon.com/AmazonS3/latest/dev/UsingAWSSDK.html

Copy link
Copy Markdown

@adamaziz15 adamaziz15 May 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nvm i'm thinking it's really just used when you're configuring the cli on a local machine maybe

Copy link
Copy Markdown
Contributor Author

@ouranos ouranos May 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah if you don't specify it adds it to default, here's what's been added to the ~/.aws/config after running the command on my machine:

[default]
s3 =
    signature_version = s3v4

AWS_ACCESS_KEY_ID=$S3_ACCESS_KEY_ID AWS_SECRET_ACCESS_KEY=$S3_SECRET_ACCESS_KEY AWS_DEFAULT_REGION=$S3_REGION aws s3 cp $opts $S3_URI ./
archive_file=${S3_URI##*/}
echo "Unzipping $archive_file"
Expand Down