[MARLIN-882] Enable S3 Signature Version 4 for aws#37
Merged
ouranos merged 1 commit intomaestrano:1.0from May 22, 2019
Merged
Conversation
Contributor
ouranos
commented
May 14, 2019
ouranos
commented
Requests specifying Server Side Encryption with AWS KMS managed keys require AWS Signature Version 4.
adamaziz15
reviewed
May 22, 2019
| opts="--no-sign-request" | ||
| fi | ||
| # Setting Signature Version 4 for S3 Request Authentication | ||
| aws configure set s3.signature_version s3v4 |
There was a problem hiding this comment.
Should this be aws configure set default.s3.signature_version s3v4? Took this from https://docs.aws.amazon.com/AmazonS3/latest/dev/UsingAWSSDK.html
There was a problem hiding this comment.
ah nvm i'm thinking it's really just used when you're configuring the cli on a local machine maybe
Contributor
Author
There was a problem hiding this comment.
Yeah if you don't specify it adds it to default, here's what's been added to the ~/.aws/config after running the command on my machine:
[default]
s3 =
signature_version = s3v4
adamaziz15
approved these changes
May 22, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.