Merged
Conversation
Bump node version
Use 2.3-stretch as the base image to be consistent with the other ruby versions. We're also using stretch to run our tests on CirleCI.
Requests specifying Server Side Encryption with AWS KMS managed keys require AWS Signature Version 4.
This reverts commit 6bb2cb3.
As we're now using stretch as base image, Python 3.5 is already installed so we only need to install pip3 and python3-dev
cesar-tonnoir
approved these changes
Jun 3, 2019
| script: | ||
| # Build docker image | ||
| - cd 2.3/ | ||
| - docker build -t maestrano/web-ruby:travis . > /dev/null 2>&1 |
There was a problem hiding this comment.
can you plz explain why this isn't required any more?
There was a problem hiding this comment.
@cesar-tonnoir looks like this was removed so we can see the docker build logs, also the 2>&1 was masking the exit code 🤔- see 43f2e36
Contributor
Author
There was a problem hiding this comment.
Yes exactly. I removed it to be able to see the docker logs when debugging and decided to keep it.
> /dev/nullredirectsstdoutto `/dev/null/2>&1redirectsstderrto where we're redirectingstdout
adamaziz15
approved these changes
Jun 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2.0 branch is only used by the reconciliation engine and needed to be updated to support KMS encrypted S3 buckets (see #37).
I took the opportunity to also port some updates done in the 1.0 branch (mainly to fix the docker build)
Main changes:
Since we're now using stretch, I was able to make the following changes: