[IMPAC-639] Add currency conversion to widget KPIs#400
Closed
xaun wants to merge 9 commits intomaestrano:release/v1.6.1from
xaun:feature/693-threshold-currency
Closed
[IMPAC-639] Add currency conversion to widget KPIs#400xaun wants to merge 9 commits intomaestrano:release/v1.6.1from xaun:feature/693-threshold-currency
xaun wants to merge 9 commits intomaestrano:release/v1.6.1from
xaun:feature/693-threshold-currency
Conversation
xaun
changed the title
cesar-tonnoir
changed the title
Contributor
cesar-tonnoir
left a comment
cesar-tonnoir
left a comment
There was a problem hiding this comment.
Last two commits look ok, but we need to merge IMPAC-622 before this PR can be merged.
|
|
||
| @update = (widget, opts, needContentReload = true) -> | ||
| widget.isLoading = needContentReload | ||
| widget.isLoading = needContentReload unless widget.isLoading |
Contributor
There was a problem hiding this comment.
'widget.isLoading ||= needContentReload' ?
| kpi.watchables = [kpi.element_watched].concat(kpi.extra_watchables || []) | ||
|
|
||
| # Logic specific to applying newly fetched data to a dhb KPI. | ||
| # TODO: Redesign all business logic for v1 / v2 dhb & widget KPIs. |
Contributor
There was a problem hiding this comment.
This comment is not really helpful: can you describe a bit more what should be reworked? What part of the current business logic is causing trouble?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.