[IMPAC-639] Threshold currency#413
Closed
xaun wants to merge 5 commits intomaestrano:1.6from
xaun:feature/693-threshold-currency2
Closed
[IMPAC-639] Threshold currency#413xaun wants to merge 5 commits intomaestrano:1.6from xaun:feature/693-threshold-currency2
xaun wants to merge 5 commits intomaestrano:1.6from
xaun:feature/693-threshold-currency2
Conversation
- changes for widget hist_parameters removed - detects dates from chart yAxis extremes - applies threshold dates from today & chart extreme - apply thresholds from #show results (applys converted targets)
cesar-tonnoir
changed the title
cesar-tonnoir
approved these changes
Oct 6, 2017
Contributor
cesar-tonnoir
left a comment
cesar-tonnoir
left a comment
There was a problem hiding this comment.
This is a nice refactor, well done :)
The change is quite consequent => make sure you describe the regression testing steps in the Jira and you test the KPIs + alerts extensively in UAT
Contributor
Author
|
@cesar-tonnoir another dormant, approved PR, any ideas? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased this feature on-top of 1.6.1. The last commit contains fixes & refactors required due the the latest changes in 1.6.1. All previous commits were reviewed here: #400.