[IMPAC-745] Fixed Cash Projection Crash #463
Closed
iseessel wants to merge 71 commits intomaestrano:1.6from
Closed
[IMPAC-745] Fixed Cash Projection Crash #463iseessel wants to merge 71 commits intomaestrano:1.6from
iseessel wants to merge 71 commits intomaestrano:1.6from
Conversation
added 2 commits
January 23, 2018 19:02
- Statement and Balance in Xero displayed - Personalised DemoData feature
Add max-height to allow overflow scroll to work.
Add ASCII encode/decoding for tag values
Widgets Templates whitelist / blacklist feature
Release/banking bolt
[IMPAC-759] Fix cash_balance accounts list
[IMPAC-750] Fix widgets templates rendering order
…rom being shown on x Axis
Fix hidden date issue
[IMPAC-763] Fixed Accounts classes comparison Dates
[IMPAC-681] Fix tags to allow special chars
[IMPAC-757] Added radio mode for organization
Contributor
Author
Fix dependency issue, travis chrome launching, & dashboard.svc specs
588a348 to
bc12307
Compare
Contributor
Author
|
@ouranos Realized I was making PR onto 1.6 and not 1.6.9. This New Pull request made. |
6c9bf95 to
415acc2
Compare
Contributor
|
Moved to PR #480 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cesar-tonnoir
Instead of calling update on highCharts multiple times new data is introduced, I created an entirely new chart. For some reason I could not figure out the create method is faster than the update for the highCharts API.
Because of this, I had to change the way the options were stored, as we need to put all the options in at once.
Additionally if an input was invalid, the create and cancel buttons would not go back to normal. I solved that by adding a tostr error and invoking #cancelCreateKpi. I don't know what the intended behavior was, but you could not choose a number less than 0.
I am also not entirely confident in how the options from the specific widgets is getting integrated into the highCharts factory. It seems like _.get is being used to retrieve options from the specific widgets and injecting them into the big options-hash in highcharts-factory.svc.coffee. I think this could be refactored to merely merging the specific widgets' options hash with these default options, but this would take some time. For this pull request, I followed the current patterns of merging options.