fix: newly added cycle doesnt appear unlelss the page is manually reloaded#2673
Merged
sriramveeraghanta merged 6 commits intomakeplane:developfrom Nov 20, 2023
Conversation
|
@AbhiShake1 is attempting to deploy a commit to the Plane Team on Vercel. A member of the Team first needs to authorize it. |
1 task
1 task
…_unlelss_the_page_is_manually_reloaded
sriramveeraghanta
approved these changes
Nov 20, 2023
sriramveeraghanta
pushed a commit
that referenced
this pull request
Dec 7, 2023
…oaded (#2673) * fix: newly added cycle doesnt appear unlelss the page is manually reloaded * Delete \ * Delete web/layouts/profile-layout/profile-sidebar.tsx * Update cycles.store.ts * fix: remove duplicate type declaration --------- Co-authored-by: Aaryan Khandelwal <65252264+aaryan610@users.noreply.github.com>
aaryan610
pushed a commit
that referenced
this pull request
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR fixes issue #2666 by using cycles instead of project details from store, which refreshes when cycles is updated. as a side effect, it also fixes the weird layout (different from the original layout) when all cycles are deleted.