Skip to content

fix: newly added cycle doesnt appear unlelss the page is manually reloaded #2673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sriramveeraghanta merged 6 commits into from
Nov 20, 2023
Merged

fix: newly added cycle doesnt appear unlelss the page is manually reloaded #2673

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
98f3412
fix: newly added cycle doesnt appear unlelss the page is manually rel…
AbhiShake1 Nov 6, 2023
ce6e697
Delete \
AbhiShake1 Nov 6, 2023
df50829
Delete web/layouts/profile-layout/profile-sidebar.tsx
AbhiShake1 Nov 6, 2023
4a4649d
Update cycles.store.ts
AbhiShake1 Nov 6, 2023
d639857
Merge branch 'develop' into 11-06-fix_newly_added_cycle_doesnt_appear…
aaryan610 Nov 20, 2023
c299621
fix: remove duplicate type declaration
aaryan610 Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions web/pages/[workspaceSlug]/projects/[projectId]/cycles/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const ProjectCyclesPage: NextPageWithLayout = observer(() => {
const [createModal, setCreateModal] = useState(false);
// store
const { project: projectStore, cycle: cycleStore } = useMobxStore();
const { currentProjectDetails } = projectStore;
const { projectCycles } = cycleStore
// router
const router = useRouter();
const { workspaceSlug, projectId, peekCycle } = router.query;
Expand Down Expand Up @@ -73,6 +73,7 @@ const ProjectCyclesPage: NextPageWithLayout = observer(() => {

const cycleView = cycleStore?.cycleView;
const cycleLayout = cycleStore?.cycleLayout;
const totalCycles = projectCycles?.length ?? 0

if (!workspaceSlug || !projectId) return null;

Expand All @@ -84,7 +85,7 @@ const ProjectCyclesPage: NextPageWithLayout = observer(() => {
isOpen={createModal}
handleClose={() => setCreateModal(false)}
/>
{currentProjectDetails?.total_cycles === 0 ? (
{totalCycles === 0 ? (
<div className="h-full grid place-items-center">
<EmptyState
title="Plan your project with cycles"
Expand Down