Skip to content

chore: posthog events improved#3554

Merged
sriramveeraghanta merged 10 commits intodevelopfrom
chore/events
Feb 5, 2024
Merged

chore: posthog events improved#3554
sriramveeraghanta merged 10 commits intodevelopfrom
chore/events

Conversation

@1akhanBaheti
Copy link
Member

@1akhanBaheti 1akhanBaheti commented Feb 2, 2024

This PR includes improvements & refactoring in the project, cycle, module, and issue related posthog events:

  1. Changed the existing naming convention of the events.
  2. Added trigger point of every event in its payload.
  3. Added special properties in issue-related events.

The project, cycle, module, and issue-related posthog event includes:

  1. Project > created, updated, deleted.
  2. Cycle > created, updated, deleted.
  3. Module > created, updated, deleted.
  4. Issue > created, updated, deleted.

Refactoring:

  1. Moved event-tracker store out of the application folder.
  2. Created event-tracker constant file which provides actual event payload to be sent.

@1akhanBaheti 1akhanBaheti changed the base branch from preview to develop February 2, 2024 15:06
@1akhanBaheti 1akhanBaheti marked this pull request as ready for review February 2, 2024 15:29
@1akhanBaheti 1akhanBaheti added this to the v0.16 milestone Feb 2, 2024
@sriramveeraghanta sriramveeraghanta merged commit 0165aba into develop Feb 5, 2024
@sriramveeraghanta sriramveeraghanta deleted the chore/events branch February 5, 2024 07:49
@srinivaspendem srinivaspendem modified the milestones: v0.16, v0.15.1-dev Feb 6, 2024
NarayanBavisetti added a commit that referenced this pull request May 8, 2024
* chore: breadcrumb component improvement (#3537)

* chore: breadcrumb component improvement

* chore: code refactor

* fix: create issue modal project select (#3549)

* chore: responsive and styling fixes (#3541)

* fix: all issues spreadsheet sorting and kanban dnd for long lists (#3550)

* fix all issues filter for spreadsheet view

* fix kanban dnd with long lists

* dev: validation for external id and external source (#3552)

* dev: error response for duplicate items created through external apis

* dev: return identifier and also add the validation for state

* fix: validation for external id and external source

* chore: cycle and module sidebar analytics improvement (#3559)

* chore: cycle and module store update action updated

* chore: cycle and module issue store actions updated

* chore: cycle and module retrieve endpoints updated

* fix: app sidebar z index and priority icon fix

* chore: cycle and module sidebar and stats updated

* chore: posthog events improved (#3554)

* chore: events naming convention changed

* chore: track element added for project related events

* chore: track element added for cycle related events

* chore: track element added for module related events

* chore: issue related events updated

* refactor: event tracker store

* refactor: event-tracker store

* fix: posthog changes

---------

Co-authored-by: sriram veeraghanta <veeraghanta.sriram@gmail.com>

* fix: build fixes

* fix: sentry error fixes

* chore: active cycle issue transfer validation (#3560)

* fix: completed cycle list layout validation

* fix: completed cycle kanban layout validation

* fix: completed cycle spreadsheet layout validation

* fix: date dropdown disabled fix

* chore: quick action validation added for list, kanban and spreadsheet layout

* fix: calendar layout validation added

* fix: useberry script added

* chore: added `None` filter option to the dashboard widgets (#3556)

* chore: added tab change animation

* chore: widgets filtering logic updated

* refactor: issues list widget

* fix: tab navigation transition

* fix: extra top spacing on opening the peek overview

* chore: removed email notification for new users (#3561)

* chore: cycle and module sidebar improvement (#3562)

* chore: module date validation (#3565)

* app_release value handled (#3571)

* chore: email trigger for new assignee (#3572)

* dev: update the response for conflicting errors (#3568)

* style: responsive breadcrumbs and headers for dashboard, projects, project issues, cycles, cycle issues, module issues (#3580)

* fix: dashboard header z index and workspace active cycles fix (#3581)

* fix: dashboard header z index fix

* chore: workspace active cycles upgrade page improvement

* fix: draft issue peek overview (#3582)

* chore: project, view and shortcut modal alignment consistency

* chore: issue highlight list layout improvement

* fix: draft issue peek overview fix

* fix: draft issue layout inline editing

* chore: module issue count (#3566)

* chore: mention notification and webhook faliure (#3573)

* fix: mention rstrip error

* chore: webhook deactivation email

* chore: changed template

* chore: current site for external api's

* chore: mention in template displayed

* chore: mention tag fix

* chore: comment user name displayed

* dev: create fake data for issues (#104)

* dev: create fake data for issues

* dev: remove endpoint

* dev: update faker script

* chore: workspace dashboard refactor (#3584)

* fix: faker import (#111)

* fix: show window closing alert only when page is not saved (#3577)

* fix: show window closing alert only when page is not saved

* chore: Refactor useReloadConfirmations hook

- Removed the `message` parameter, as it was not being used and not
  supported in modern browsers
- Changed the `isActive` flag to a temporary flag and added a TODO comment to remove it later.
- Implemented the `handleRouteChangeStart` function to handle route change events and prompt the user with a confirmation dialog before leaving the page.
- Updated the dependencies of the `handleBeforeUnload` and `handleRouteChangeStart` callbacks.
- Added event listeners for `beforeunload` and `routeChangeStart` events in the `useEffect` hook.
- Cleaned up the event listeners in the cleanup function of the `useEffect` hook.

fix: Fix reload confirmations in PageDetailsPage

- Removed the TODO comment regarding fixing reload confirmations with MobX, as it has been resolved.
- Passed the `pageStore?.isSubmitting === "submitting"` flag to the `useReloadConfirmations` hook instead of an undefined message.

This commit refactors the `useReloadConfirmations` hook to improve its functionality and fixes the usage in the `PageDetailsPage` component.

---------

Co-authored-by: Palanikannan1437 <73993394+Palanikannan1437@users.noreply.github.com>

* chore: posthog code refactor (#3586)

* dev: update faker script to take inputs (#112)

* dev: update faker script to take inputs

* dev: update while check

---------

Co-authored-by: Anmol Singh Bhatia <121005188+anmolsinghbhatia@users.noreply.github.com>
Co-authored-by: Ramesh Kumar Chandra <31303617+rameshkumarchandra@users.noreply.github.com>
Co-authored-by: rahulramesha <71900764+rahulramesha@users.noreply.github.com>
Co-authored-by: Nikhil <118773738+pablohashescobar@users.noreply.github.com>
Co-authored-by: Lakhan Baheti <94619783+1akhanBaheti@users.noreply.github.com>
Co-authored-by: Aaryan Khandelwal <65252264+aaryan610@users.noreply.github.com>
Co-authored-by: Bavisetti Narayan <72156168+NarayanBavisetti@users.noreply.github.com>
Co-authored-by: Manish Gupta <59428681+mguptahub@users.noreply.github.com>
Co-authored-by: João Lucas de Oliveira Lopes <55464917+jlucaso1@users.noreply.github.com>
Co-authored-by: Palanikannan1437 <73993394+Palanikannan1437@users.noreply.github.com>
vamsikrishnamathala pushed a commit that referenced this pull request Aug 7, 2025
* refactor: update AMI and CloudFormation template handling in CI workflow

- Removed previous manifest file references and associated cleanup steps from the CI workflow.
- Updated S3 paths for storing the latest and versioned AMI manifests.
- Introduced a new step to store the CloudFormation template in S3 with updated paths.
- Enhanced the CloudFormation template to include a parameter for AMI ID, replacing the previous region-based mapping.
- Improved AMI naming convention in Packer configuration to include a timestamp.

* chore: enhance cleanup commands in Packer configuration for AMI builds

- Added removal of authorized_keys for the root user to improve security during AMI creation.
- Included command to clear command history to further secure the AMI environment.

* chore: improve cleanup commands in Packer configuration for AMI builds

- Replaced command to clear command history with specific removal of .bash_history files for both ubuntu and root users.
- Enhanced security measures during AMI creation by ensuring sensitive history data is removed.

* chore: refine cleanup commands in Packer configuration for AMI builds

- Updated command to remove command history files for both ubuntu and root users to a more general pattern, enhancing security during AMI creation.

* feat: add SSH and Application Security Group CIDR parameters to CloudFormation template

- Introduced new parameters for SSH and Application Security Group CIDR configurations, allowing for more granular control over access.
- Updated metadata and validation assertions to ensure these parameters are required when creating new infrastructure.
- Modified security group rules to reference the new CIDR parameters for SSH, HTTP, and HTTPS access.

* fix: update PublicSubnetCidr default value in CloudFormation template

- Changed the default value of PublicSubnetCidr from "10.50.1.0/16" to "10.50.1.0/24" to better align with subnetting requirements for new infrastructure.

* chore: update default values for SSH and Application Security Group CIDR parameters in CloudFormation template

- Changed the default values for SshSecurityGroupCidr and ApplicationSecurityGroupCidr from "0.0.0.0/0" to an empty string to enforce explicit configuration of access controls.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants