[WEB-1936] fix: flicker issue while viewing sub issues

[gakshita]

Summary
While viewing the sub issues, there was an unintended flickering due to a specific height. Fixed it by inheriting the height from the parent

[WEB-1936]

Summary by CodeRabbit

• New Features

  • Enhanced layout flexibility by allowing the height of components to adapt to their parent container's size.

• Bug Fixes

  • Improved responsiveness and adaptability of the IssueBlockRoot component for varying content sizes.

[coderabbitai]

Walkthrough

The recent update modifies the defaultHeight property of the RenderIfVisible component within the IssueBlockRoot functional component. By changing the height from a fixed value of "3rem" to "inherit," the component gains flexibility, allowing it to adjust its height based on the parent container. This change improves responsiveness and integration within varying layouts, enhancing the overall adaptability of the design while maintaining existing functionality.

Changes

File Path	Change Summary
web/core/components/issues/issue-layouts/list/block-root.tsx	Changed defaultHeight from "3rem" to "inherit" in RenderIfVisible component.

Poem

Hop along the code, with heights that flow,
A change so simple, yet watch it grow!
From fixed to free, like a breeze in spring,
Our layouts dance, and the rabbits sing!
With every line, our joy expands,
In the world of code, where magic stands! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 66c2cbe and d043666.

Files selected for processing (1)

• web/core/components/issues/issue-layouts/list/block-root.tsx (1 hunks)

Additional comments not posted (1)

web/core/components/issues/issue-layouts/list/block-root.tsx (1)

125-125: LGTM! Ensure no unintended side effects.

The change to defaultHeight="inherit" improves the flexibility and responsiveness of the RenderIfVisible component.

Please verify that this change does not introduce any unintended side effects, such as layout shifts or visual inconsistencies in different parent containers.

[SatishGandham]

Did you check how it affects virtualisation, scrolling and quick add?

[rahulramesha]

code should be fine but as Satish mentioned please check while virtualization while scrolling