[WEB-1936] fix: Revert issue height change#5238
Conversation
WalkthroughThe recent change modifies the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- web/core/components/issues/issue-layouts/list/block-root.tsx (1 hunks)
Additional comments not posted (1)
web/core/components/issues/issue-layouts/list/block-root.tsx (1)
125-125: Assess the impact of setting a fixed height.Changing the
defaultHeightfrom"inherit"to"3rem"sets a fixed height for theRenderIfVisiblecomponent. This can affect the layout and visual presentation, especially in responsive designs that previously relied on dynamic height adjustments. Ensure that this change does not negatively impact the user experience across different devices and screen sizes.
Summary
Revoked changes of this PR as it is breaking the loaders in issues list layout with grouping.
[WEB-1936]
Summary by CodeRabbit
New Features
IssueBlockRootcomponent, enhancing visual stability in layouts.Bug Fixes