Skip to content

[WEB-2320] fix: Redirect to issues page post issue deletion deletion #5437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SatishGandham merged 1 commit into from
Aug 27, 2024
Merged

[WEB-2320] fix: Redirect to issues page post issue deletion deletion #5437

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions web/core/components/issues/issue-detail/issue-detail-quick-actions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,18 +78,19 @@ export const IssueDetailQuickActions: FC<Props> = observer((props) => {

const handleDeleteIssue = async () => {
try {
if (issue?.archived_at) {
return removeArchivedIssue(workspaceSlug, projectId, issueId).then(() => {
router.push(`/${workspaceSlug}/projects/${projectId}/issues`);
captureIssueEvent({
eventName: ISSUE_DELETED,
payload: { id: issueId, state: "SUCCESS", element: "Issue detail page" },
path: pathname,
});
const deleteIssue = issue?.archived_at ? removeArchivedIssue : removeIssue;
const redirectionPath = issue?.archived_at
? `/${workspaceSlug}/projects/${projectId}/archives/issues`
: `/${workspaceSlug}/projects/${projectId}/issues`;

return deleteIssue(workspaceSlug, projectId, issueId).then(() => {
router.push(redirectionPath);
captureIssueEvent({
eventName: ISSUE_DELETED,
payload: { id: issueId, state: "SUCCESS", element: "Issue detail page" },
path: pathname,
});
} else {
return removeIssue(workspaceSlug, projectId, issueId);
}
});
Comment on lines +86 to +93
Copy link
Contributor

@coderabbitai coderabbitai bot Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure proper error handling

The refactored code correctly handles errors by displaying a toast message and capturing the issue event. However, consider logging the error for debugging purposes.

 try {
   const deleteIssue = issue?.archived_at ? removeArchivedIssue : removeIssue;
   const redirectionPath = issue?.archived_at
     ? `/${workspaceSlug}/projects/${projectId}/archives/issues`
     : `/${workspaceSlug}/projects/${projectId}/issues`;

   return deleteIssue(workspaceSlug, projectId, issueId).then(() => {
     router.push(redirectionPath);
     captureIssueEvent({
       eventName: ISSUE_DELETED,
       payload: { id: issueId, state: "SUCCESS", element: "Issue detail page" },
       path: pathname,
     });
   });
 } catch (error) {
+  console.error("Error deleting issue:", error);
   setToast({
     title: "Error!",
     type: TOAST_TYPE.ERROR,
     message: "Issue delete failed",
   });
   captureIssueEvent({
     eventName: ISSUE_DELETED,
     payload: { id: issueId, state: "FAILED", element: "Issue detail page" },
     path: pathname,
   });
 }

Consider logging the error for debugging purposes.

Committable suggestion was skipped due to low confidence.

} catch (error) {
setToast({
title: "Error!",
Expand Down