Skip to content

[WEB-2367] fix: completed cycle issue transfer #5494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pushya22 merged 1 commit into from
Sep 2, 2024
Merged

[WEB-2367] fix: completed cycle issue transfer #5494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 4 additions & 31 deletions web/core/components/cycles/transfer-issues.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,52 +1,25 @@
"use client";

import React from "react";

import isEmpty from "lodash/isEmpty";
import { useParams } from "next/navigation";

import useSWR from "swr";

// component
import { AlertCircle } from "lucide-react";
// ui
import { Button, TransferIcon } from "@plane/ui";
// icon
// services
import { CYCLE_DETAILS } from "@/constants/fetch-keys";
import { CycleService } from "@/services/cycle.service";
// fetch-key

type Props = {
handleClick: () => void;
canTransferIssues?: boolean;
disabled?: boolean;
};

const cycleService = new CycleService();

export const TransferIssues: React.FC<Props> = (props) => {
const { handleClick, disabled = false } = props;

const { workspaceSlug, projectId, cycleId } = useParams();

const { data: cycleDetails } = useSWR(
cycleId ? CYCLE_DETAILS(cycleId as string) : null,
workspaceSlug && projectId && cycleId
? () => cycleService.getCycleDetails(workspaceSlug as string, projectId as string, cycleId as string)
: null
);

const transferableIssuesCount = cycleDetails
? cycleDetails.backlog_issues + cycleDetails.unstarted_issues + cycleDetails.started_issues
: 0;

const { handleClick, canTransferIssues = false, disabled = false } = props;
return (
<div className="-mt-2 mb-4 flex items-center justify-between px-4 pt-6">
<div className="flex items-center gap-2 text-sm text-custom-text-200">
<AlertCircle className="h-3.5 w-3.5 text-custom-text-200" />
<span>Completed cycles are not editable.</span>
</div>

{isEmpty(cycleDetails?.progress_snapshot) && transferableIssuesCount > 0 && (
{canTransferIssues && (
<div>
<Button
variant="primary"
Expand Down
6 changes: 6 additions & 0 deletions web/core/components/issues/issue-layouts/roots/cycle-layout-root.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,11 @@ export const CycleLayoutRoot: React.FC = observer(() => {
const cycleDetails = cycleId ? getCycleById(cycleId.toString()) : undefined;
const cycleStatus = cycleDetails?.status?.toLocaleLowerCase() ?? "draft";
const isCompletedCycle = cycleStatus === "completed";
const isProgressSnapshotEmpty = isEmpty(cycleDetails?.progress_snapshot);
const transferableIssuesCount = cycleDetails
? cycleDetails.backlog_issues + cycleDetails.unstarted_issues + cycleDetails.started_issues
: 0;
const canTransferIssues = isProgressSnapshotEmpty && transferableIssuesCount > 0;

if (!workspaceSlug || !projectId || !cycleId) return <></>;

Expand All @@ -77,6 +82,7 @@ export const CycleLayoutRoot: React.FC = observer(() => {
{cycleStatus === "completed" && (
<TransferIssues
handleClick={() => setTransferIssuesModal(true)}
canTransferIssues={canTransferIssues}
disabled={!isEmpty(cycleDetails?.progress_snapshot) ?? false}
/>
)}
Expand Down