[WEB-2367] fix: completed cycle issue transfer

[anmolsinghbhatia]

Changes:

This PR fixes a bug related to issue transfer after cycle completion. The transfer issue button wasn't rendering correctly due to a recent change in the response.

Reference:

[WEB-2367]

Summary by CodeRabbit

• New Features

  • Enhanced the TransferIssues component to conditionally display the transfer button based on the canTransferIssues property.
  • Improved logic in the CycleLayoutRoot component to determine the transferability of issues based on the cycle's progress and available transferable issues.

• Bug Fixes

  • Streamlined functionality by removing unnecessary data fetching, ensuring the transfer button reflects the current state accurately.

[coderabbitai]

Walkthrough

The changes involve modifications to the TransferIssues and CycleLayoutRoot components. The TransferIssues component has been simplified by removing dynamic data fetching and restructuring its logic to rely on a new canTransferIssues prop. The CycleLayoutRoot component now includes logic to determine issue transferability based on the cycle's progress and the count of transferable issues, enhancing the interaction between components.

Changes

Files	Change Summary
web/core/components/cycles/transfer-issues.tsx	Removed imports and useSWR hook; updated Props type to include canTransferIssues; simplified functionality.
web/core/components/issues/issue-layouts/roots/cycle-layout-root.tsx	Introduced logic for determining canTransferIssues based on cycle progress and transferable issue count; passed prop to TransferIssues.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CycleLayoutRoot
    participant TransferIssues

    User->>CycleLayoutRoot: Request to view cycle
    CycleLayoutRoot->>CycleLayoutRoot: Determine transferable issues
    CycleLayoutRoot->>TransferIssues: Pass canTransferIssues
    TransferIssues->>User: Display transfer button based on canTransferIssues

Loading

Poem

🐰
In the meadow where cycles play,
Issues dance in a bright array.
With a button to transfer, oh what fun,
Hopping along, our work is done!
Changes made, so smooth and light,
Let’s celebrate with joy tonight!
🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

Early access features: disabled

We are currently testing the following features in early access:

• Anthropic claude-3-5-sonnet for code reviews: Anthropic claims that the new Claude model has stronger code understanding and code generation capabilities than their previous models. Note: Our default code review model was also updated late last week. Please compare the quality of the reviews between the two models by toggling the early access feature.

Note:

• You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
• Please join our Discord Community to provide feedback and report issues on the discussion post.

[coderabbitai]

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)

web/core/components/cycles/transfer-issues.tsx (1)

4-4: Remove the unnecessary comment.

The comment // ui doesn't provide any useful information and can be removed.

Apply this diff to remove the comment:

-// ui

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2c95071 and a2d9e63.

Files selected for processing (2)

• web/core/components/cycles/transfer-issues.tsx (1 hunks)
• web/core/components/issues/issue-layouts/roots/cycle-layout-root.tsx (2 hunks)

Additional comments not posted (4)

web/core/components/cycles/transfer-issues.tsx (2)

9-9: LGTM!

The new canTransferIssues prop simplifies the component's logic and removes the dependency on fetched data. The change is consistent with the PR summary and the AI-generated summary.

---

14-22: LGTM!

The change simplifies the component's logic by removing the dependency on fetched data and relying on the canTransferIssues prop to determine the button's visibility. The change is consistent with the PR summary and the AI-generated summary.

web/core/components/issues/issue-layouts/roots/cycle-layout-root.tsx (2)

70-74: LGTM!

The code changes introduce the necessary logic to determine the transferability of issues based on the cycle's progress snapshot and the count of transferable issues. The use of the isEmpty function from the lodash library is appropriate for checking if the progress_snapshot is empty, and the calculation of transferableIssuesCount correctly sums up the relevant issue counts.

---

85-85: LGTM!

Passing the canTransferIssues prop to the TransferIssues component is a good way to conditionally enable or disable the transfer functionality based on the calculated state. This enhances the component's interactivity and ensures that the transfer button reflects the current state of the cycle's issues more accurately.