Skip to content

Comments

[WEB-3235]fix: transfer issues button mutation#6549

Merged
sriramveeraghanta merged 3 commits intopreviewfrom
fix-transfer-issues
Feb 10, 2025
Merged

[WEB-3235]fix: transfer issues button mutation#6549
sriramveeraghanta merged 3 commits intopreviewfrom
fix-transfer-issues

Conversation

@vamsikrishnamathala
Copy link
Member

@vamsikrishnamathala vamsikrishnamathala commented Feb 5, 2025

Description

This update fixes the mutation issue for transfer issues

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Improvement (change that would cause existing functionality to not work as expected)
  • Code refactoring
  • Performance improvements
  • Documentation update

Screenshots and Media (if applicable)

Test Scenarios

References

WEB-3235

Summary by CodeRabbit

  • Refactor
    • Cycle overviews now display a refined issue count that focuses on cancelled issues, offering clearer insight.
    • The calculation for transferable tasks has been updated so that the transfer option appears only when actionable issues exist.
    • Updated logic for determining transferable issues enhances clarity and accuracy in the display of relevant counts.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2025

Walkthrough

The changes update the management of issue counts within a cycle. The backend renames and filters issue counts in the CycleViewSet, replacing pending_issues with cancelled_issues and limiting counts to cancelled issues only. The pending_issues property is removed from the ICycle interface. Frontend components are modified to compute and display transferable issues using a new variable that calculates the total issues minus cancelled and completed issues.

Changes

File(s) Change Summary
apiserver/…/views/cycle/base.py
packages/types/…/cycle.d.ts
Renamed pending_issues to cancelled_issues and updated filtering in CycleViewSet.
Removed the pending_issues property from the ICycle interface.
web/core/components/cycles/list/cycle-list-item-action.tsx
web/core/components/cycles/quick-actions.tsx
Introduced transferableIssuesCount to compute transferable issues as total issues minus cancelled and completed issues.
Updated condition checks and displayed text accordingly.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant CycleViewSet
    participant Database

    Client->>CycleViewSet: Request cycle data
    CycleViewSet->>Database: Query cycles filtering for cancelled issues
    Database-->>CycleViewSet: Return cycle data with cancelled issues count
    CycleViewSet-->>Client: Send cycle data response
Loading
sequenceDiagram
    participant User
    participant CycleListItemAction
    participant CycleQuickActions

    User->>CycleListItemAction: Request cycle details view
    CycleListItemAction->>CycleQuickActions: Compute transferableIssuesCount (total - cancelled - completed)
    CycleQuickActions-->>User: Display transferable issues information
Loading

Possibly related PRs

Suggested reviewers

  • rahulramesha
  • sriramveeraghanta
  • anmolsinghbhatia

Poem

I'm a little rabbit, hopping with delight,
Changes in cycles now shine so bright.
cancelled_issues now takes the stage,
Transferable counts on a fresh new page.
With code so spry, I dance tonight!
🐰🌟


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c9b3730 and 1099f93.

📒 Files selected for processing (2)
  • web/core/components/cycles/list/cycle-list-item-action.tsx (2 hunks)
  • web/core/components/cycles/quick-actions.tsx (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • web/core/components/cycles/list/cycle-list-item-action.tsx
  • web/core/components/cycles/quick-actions.tsx
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Analyze (javascript)
  • GitHub Check: Analyze (python)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sriramveeraghanta sriramveeraghanta merged commit 8efe692 into preview Feb 10, 2025
9 of 14 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix-transfer-issues branch February 10, 2025 14:03
lifeiscontent pushed a commit that referenced this pull request Aug 18, 2025
* fix: pending issues mutation

* fix: transfer issues count
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛bug Something isn't working 🌐frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants