[WEB-2332] fix: application layout and minor UI improvements. by prateekshourya29 · Pull Request #5514 · makeplane/plane

prateekshourya29 · 2024-09-04T09:49:55Z

Summary by CodeRabbit

New Features
- Improved layout structure by simplifying the HTML elements in the RootLayout component, enhancing rendering performance.
- Enhanced styling for the IssueView component in side-peek mode, improving visual presentation.
Chores
- Removed unnecessary import of ERowVariant in the workspace notifications sidebar component, streamlining code and reducing dependencies.
- Updated the import source for the TProject type, aligning it with a new module structure.
Bug Fixes
- Removed the .app-container class, potentially improving layout management and component rendering behavior.

coderabbitai · 2024-09-04T09:50:06Z

Walkthrough

The recent changes involve structural modifications to the layout and styling of components in the application. The RootLayout component has been streamlined by removing unnecessary wrapper elements and adjusting the context menu rendering. The IssueView component has updated CSS class assignments based on the peekMode, enhancing its visual presentation. Additionally, the .app-container CSS class has been removed from the global styles, impacting layout management. Lastly, import statements in two components have been updated to simplify dependencies.

Changes

Files	Change Summary
`web/app/layout.tsx`	Simplified `<body>` structure, removed `className`, adjusted context menu placement, and streamlined layout.
`web/core/components/issues/peek-overview/view.tsx`	Modified CSS class assignment for `peekMode` to enhance styling in side-peek mode.
`web/styles/globals.css`	Removed `.app-container` class, affecting layout properties and element containment management.
`web/core/components/workspace-notifications/sidebar/root.tsx`	Removed import of `ERowVariant`, simplifying component dependencies.
`web/core/components/issues/filters.tsx`	Updated import of `TProject` type from `ee/types` to `@/plane-web/types`, changing its source.

Poem

🐰 In a world where layouts dance,
A rabbit hops with joyful prance.
Borders shift and classes flee,
Simplified paths, oh, what glee!
With every change, we bounce and cheer,
For clearer views, we hold so dear! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 22656d0 and b2c2f89.

Files selected for processing (3)

web/app/layout.tsx (1 hunks)
web/core/components/issues/peek-overview/view.tsx (1 hunks)
web/styles/globals.css (1 hunks)

Files skipped from review due to trivial changes (1)

web/styles/globals.css

Additional comments not posted (3)

web/app/layout.tsx (2)

75-75: Verify the impact of removing the h-screen w-screen classes from the <body> tag.

Ensure that the removal of these classes does not break the layout or cause any visual regressions.

Run the following script to verify the layout:

76-76: Verify the impact of moving the <div> with the ID context-menu-portal outside of the AppProvider component.

Ensure that this change does not break the rendering of context menus or cause any visual regressions.

Run the following script to verify the usage of context-menu-portal:

web/core/components/issues/peek-overview/view.tsx (1)

107-110: LGTM!

The changes to the CSS class assignment based on the peekMode condition look good. The additional class border-0 border-l when peekMode is set to "side-peek" will enhance the styling of the component by removing the border and adding a left border in side-peek mode. The changes are consistent with the existing logic flow of the component.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b2c2f89 and 4f4cf53.

Files selected for processing (1)

web/core/components/workspace-notifications/sidebar/root.tsx (1 hunks)

Files skipped from review due to trivial changes (1)

web/core/components/workspace-notifications/sidebar/root.tsx

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4f4cf53 and bd1824b.

Files selected for processing (1)

web/core/components/issues/filters.tsx (2 hunks)

Additional comments not posted (1)

web/core/components/issues/filters.tsx (1)

21-22: LGTM!

The import statement change for TProject type is approved.

prateekshourya29 added 4 commits August 28, 2024 15:30

[WEB-2332] fix: application layout and minor UI improvements.

694d27c

[WEB-2332] fix: revert back layout changes.

688db87

Merge branch 'fix/layout' of github.com:makeplane/plane into fix/layout

be1d7b9

Merge branch 'preview' of github.com:makeplane/plane into fix/layout

b2c2f89

prateekshourya29 requested a review from SatishGandham September 4, 2024 09:49

prateekshourya29 self-assigned this Sep 4, 2024

prateekshourya29 changed the title ~~fix: application layout and minor UI improvements.~~ [WEB-2332] fix: application layout and minor UI improvements. Sep 4, 2024

coderabbitai bot reviewed Sep 4, 2024

View reviewed changes

fix: lint error.

4f4cf53

coderabbitai bot reviewed Sep 4, 2024

View reviewed changes

SatishGandham approved these changes Sep 4, 2024

View reviewed changes

fix: lint errors.

bd1824b

coderabbitai bot reviewed Sep 4, 2024

View reviewed changes

SatishGandham merged commit 20b1558 into preview Sep 4, 2024

SatishGandham deleted the fix/layout branch September 4, 2024 10:39

This was referenced Jan 27, 2025

[WEB-3237, 3238] dev: date picker enhancements #6466

Closed

[WEB-3237, 3238] dev: date picker enhancements #6470

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WEB-2332] fix: application layout and minor UI improvements.#5514

[WEB-2332] fix: application layout and minor UI improvements.#5514
SatishGandham merged 6 commits intopreviewfrom
fix/layout

prateekshourya29 commented Sep 4, 2024 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Sep 4, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

prateekshourya29 commented Sep 4, 2024 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Sep 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

prateekshourya29 commented Sep 4, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 4, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)