Skip to content

[WEB-2332] fix: application layout and minor UI improvements. #5514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SatishGandham merged 6 commits into from
Sep 4, 2024
Merged

[WEB-2332] fix: application layout and minor UI improvements. #5514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
694d27c
[WEB-2332] fix: application layout and minor UI improvements.
prateekshourya29 Aug 28, 2024
688db87
[WEB-2332] fix: revert back layout changes.
prateekshourya29 Sep 4, 2024
be1d7b9
Merge branch 'fix/layout' of github.com:makeplane/plane into fix/layout
prateekshourya29 Sep 4, 2024
b2c2f89
Merge branch 'preview' of github.com:makeplane/plane into fix/layout
prateekshourya29 Sep 4, 2024
4f4cf53
fix: lint error.
prateekshourya29 Sep 4, 2024
bd1824b
fix: lint errors.
prateekshourya29 Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions web/app/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,10 @@ export default function RootLayout({ children }: { children: React.ReactNode })
crossOrigin="use-credentials"
/>
</head>
<body className={`h-screen w-screen`}>
<body>
<div id="context-menu-portal" />
<AppProvider>
<div className={`app-container h-full w-full flex flex-col overflow-hidden`}>
<div id="context-menu-portal" />
<div className="h-full w-full overflow-hidden bg-custom-background-100">{children}</div>
</div>
<div className={`h-screen w-full overflow-hidden bg-custom-background-100`}>{children}</div>
</AppProvider>
</body>
{process.env.NEXT_PUBLIC_PLAUSIBLE_DOMAIN && (
Expand Down
4 changes: 3 additions & 1 deletion web/core/components/issues/filters.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
"use client";

import { useCallback, useState } from "react";
import { TProject } from "ee/types";
// types
import { IIssueDisplayFilterOptions, IIssueDisplayProperties, IIssueFilterOptions } from "@plane/types";
// ui
Expand All @@ -19,6 +18,9 @@ import {
import { isIssueFilterActive } from "@/helpers/filter.helper";
// hooks
import { useLabel, useProjectState, useMember, useIssues } from "@/hooks/store";
// plane web types
import { TProject } from "@/plane-web/types";
// local components
import { ProjectAnalyticsModal } from "../analytics";

type Props = {
Expand Down
2 changes: 1 addition & 1 deletion web/core/components/issues/peek-overview/view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ export const IssueView: FC<IIssueView> = observer((props) => {
? "fixed z-20 flex flex-col overflow-hidden rounded border border-custom-border-200 bg-custom-background-100 transition-all duration-300"
: `w-full h-full`,
!embedIssue && {
"bottom-0 right-0 top-0 w-full md:w-[50%]": peekMode === "side-peek",
"bottom-0 right-0 top-0 w-full md:w-[50%] border-0 border-l": peekMode === "side-peek",
"size-5/6 top-[8.33%] left-[8.33%]": peekMode === "modal",
"inset-0 m-4": peekMode === "full-screen",
}
Expand Down
2 changes: 1 addition & 1 deletion web/core/components/workspace-notifications/sidebar/root.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { FC } from "react";
import { observer } from "mobx-react";
import { useParams } from "next/navigation";
// components
import { CustomHeader, CustomRow, EHeaderVariant, ERowVariant } from "@plane/ui";
import { CustomHeader, CustomRow, EHeaderVariant } from "@plane/ui";
import { CountChip } from "@/components/common";
import {
NotificationsLoader,
Expand Down
6 changes: 0 additions & 6 deletions web/styles/globals.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,12 +359,6 @@ body {
color: rgba(var(--color-text-100));
}

.app-container {
contain: layout style size;
contain-intrinsic-size: 100%;
position: relative; /* Ensure it's the containing block */
}

/* scrollbar style */
::-webkit-scrollbar {
display: none;
Expand Down