[WEB-2415] fix:remove input type to fix image upload

[sharma01ketan]

[WEB-2415]

The input type is removed as it was causing trouble if no prior background image is present, same is done for all other required places.

Summary by CodeRabbit

Summary by CodeRabbit

• New Features

  • Simplified the input declaration in the Image Picker component and related modals by removing the type attribute, enhancing flexibility in input handling.

• Bug Fixes

  • No bug fixes were implemented in this release.

• Documentation

  • No updates to documentation were made in this release.

• Refactor

  • Streamlined the input elements across multiple components for improved usability without changing their core functionality.

[coderabbitai]

Walkthrough

The pull request modifies several components by removing the type attribute from <input> elements, allowing them to default to "text". This change simplifies the input declarations across the components without fundamentally altering their overall functionality, as they will still accept text input.

Changes

File	Change Summary
web/core/components/core/image-picker-popover.tsx, web/core/components/core/modals/user-image-upload-modal.tsx, web/core/components/core/modals/workspace-image-upload-modal.tsx	Removed type attribute from <input> elements, defaulting to "text".

Possibly related PRs

• [WEB-2201] fix: clear email button on login screen #5546: The changes in the UserImageUploadModal and WorkspaceImageUploadModal components involve similar modifications to input attributes, specifically the removal of the type attribute.
• [WEB-2361] fix: Sidebar loosing its collapse context of on refresh and on changing the size of the window #5549: The WorkspaceImageUploadModal also modifies input attributes, indicating a related focus on input handling across these components.

Poem

🐰 In the meadow where inputs play,
A change was made, oh what a day!
The type was dropped, now text is free,
Simplifying joy, just wait and see!
Hops of delight in every line,
A clearer path, oh how divine! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8cf1c2d and 96acdf9.

Files selected for processing (1)

• web/core/components/core/image-picker-popover.tsx (1 hunks)

Files skipped from review due to trivial changes (1)

• web/core/components/core/image-picker-popover.tsx

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 96acdf9 and fbad697.

Files selected for processing (2)

• web/core/components/core/modals/user-image-upload-modal.tsx (1 hunks)
• web/core/components/core/modals/workspace-image-upload-modal.tsx (1 hunks)

Files skipped from review due to trivial changes (1)

• web/core/components/core/modals/workspace-image-upload-modal.tsx

Additional comments not posted (1)

web/core/components/core/modals/user-image-upload-modal.tsx (1)

147-147: Verify the behavior of react-dropzone with respect to handling the input type.

The removal of the type attribute from the <input> element on line 147 is intended to fix an issue with image uploads. However, it's crucial to verify that react-dropzone handles the input type correctly, as removing the type attribute will default it to "text", which is not suitable for file uploads.

Run the following script to verify the behavior of react-dropzone: