Skip to content

[WEB-2425] fix:changes for web-2425 #5616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pushya22 merged 2 commits into from
Sep 19, 2024
+2 −1
Merged

[WEB-2425] fix:changes for web-2425 #5616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23bb6ab
changes for web-2425
sharma01ketan Sep 16, 2024
f35e85b
Merge branch 'preview' of https://github.com/makeplane/plane into fix…
sharma01ketan Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions web/ce/components/issues/worklog/activity/filter-root.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { TActivityFilters, ACTIVITY_FILTER_TYPE_OPTIONS, TActivityFilterOption }
export type TActivityFilterRoot = {
selectedFilters: TActivityFilters[];
toggleFilter: (filter: TActivityFilters) => void;
isIntakeIssue?: boolean;
};

export const ActivityFilterRoot: FC<TActivityFilterRoot> = (props) => {
Expand Down
2 changes: 1 addition & 1 deletion web/core/components/issues/issue-detail/issue-activity/root.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ export const IssueActivity: FC<TIssueActivity> = observer((props) => {
disabled={disabled}
/>
)}
<ActivityFilterRoot selectedFilters={selectedFilters} toggleFilter={toggleFilter} />
<ActivityFilterRoot selectedFilters={selectedFilters} toggleFilter={toggleFilter} isIntakeIssue={isIntakeIssue}/>
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip

Codebase Verification

Unused prop in ActivityFilterRoot component

The isIntakeIssue prop is correctly defined in the ActivityFilterRoot component's prop type, but it's not being used in the component's implementation. This could lead to confusion for developers using the component.

Consider one of the following actions:

  • If the prop is intended for future use, add a TODO comment explaining its purpose.
  • If the prop is no longer needed, remove it from the component's prop type.
  • If the prop should be used, implement the necessary logic within the component.
Analysis chain

LGTM!

The isIntakeIssue prop is being passed correctly to the ActivityFilterRoot component.

Verify that the ActivityFilterRoot component is expecting and handling the new isIntakeIssue prop correctly. Run the following script to check the component implementation:

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify `ActivityFilterRoot` component implementation.

# Test: Search for the component declaration and usage. Expect: `isIntakeIssue` prop should be declared and used.
rg --type typescript -A 5 $'ActivityFilterRoot'

Length of output: 81

Script:

#!/bin/bash
# Description: Search for ActivityFilterRoot component implementation

# Find TypeScript files and search for ActivityFilterRoot
fd -e ts -e tsx | xargs rg -n -C 5 'ActivityFilterRoot'

Length of output: 4091

Script:

#!/bin/bash
# Description: Examine the full implementation of ActivityFilterRoot component

# Display the entire content of the file containing ActivityFilterRoot
fd -e tsx -e ts | xargs rg -l 'export const ActivityFilterRoot' | xargs cat

Length of output: 1037

</div>
</div>

Expand Down